Skip to content

Commit

Permalink
test: http2 session operations after destroy
Browse files Browse the repository at this point in the history
Refs #14985

PR-URL: #15758
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
  • Loading branch information
trivikr authored and MylesBorins committed Oct 23, 2017
1 parent 65c5d0e commit c07d757
Showing 1 changed file with 31 additions and 11 deletions.
42 changes: 31 additions & 11 deletions test/parallel/test-http2-server-stream-session-destroy.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,6 @@ const server = h2.createServer();
server.on(
'stream',
common.mustCall((stream) => {
const errorObj = {
type: Error,
code: 'ERR_HTTP2_INVALID_STREAM',
message: 'The stream has been destroyed'
};
stream.session.destroy();

// Test that stream.state getter returns an empty object
Expand All @@ -24,15 +19,40 @@ server.on(

// Test that ERR_HTTP2_INVALID_STREAM is thrown while calling
// stream operations after the stream session has been destroyed
common.expectsError(() => stream.additionalHeaders(), errorObj);
common.expectsError(() => stream.priority(), errorObj);
const invalidStreamError = {
type: Error,
code: 'ERR_HTTP2_INVALID_STREAM',
message: 'The stream has been destroyed'
};
common.expectsError(() => stream.additionalHeaders(), invalidStreamError);
common.expectsError(() => stream.priority(), invalidStreamError);
common.expectsError(
() => stream.pushStream({}, common.mustNotCall()),
errorObj
invalidStreamError
);
common.expectsError(() => stream.respond(), errorObj);
common.expectsError(() => stream.rstStream(), errorObj);
common.expectsError(() => stream.write('data'), errorObj);
common.expectsError(() => stream.respond(), invalidStreamError);
common.expectsError(() => stream.rstStream(), invalidStreamError);
common.expectsError(() => stream.write('data'), invalidStreamError);

// Test that ERR_HTTP2_INVALID_SESSION is thrown while calling
// session operations after the stream session has been destroyed
const invalidSessionError = {
type: Error,
code: 'ERR_HTTP2_INVALID_SESSION',
message: 'The session has been destroyed'
};
common.expectsError(() => stream.session.priority(), invalidSessionError);
common.expectsError(() => stream.session.settings(), invalidSessionError);
common.expectsError(() => stream.session.shutdown(), invalidSessionError);

// Wait for setImmediate call from destroy() to complete
// so that state.destroyed is set to true
setImmediate((session) => {
common.expectsError(() => session.priority(), invalidSessionError);
common.expectsError(() => session.settings(), invalidSessionError);
common.expectsError(() => session.shutdown(), invalidSessionError);
common.expectsError(() => session.rstStream(), invalidSessionError);
}, stream.session);
})
);

Expand Down

0 comments on commit c07d757

Please sign in to comment.