Skip to content

Commit

Permalink
doc: add note about autocrlf required for tests
Browse files Browse the repository at this point in the history
Adds a note to test/README.md that setting autocrlf to true when
checking out sources is required for the tests to run successfully.

PR-URL: #20752
Ref: #18967
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
  • Loading branch information
bzoz authored and MylesBorins committed May 23, 2018
1 parent d9aecc0 commit c1fe9b2
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions test/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ directory, see [the guide on writing tests](../doc/guides/writing-tests.md).
On how to run tests in this directory, see
[the contributing guide](../doc/guides/contributing/pull-requests.md#step-6-test).

For the tests to successfully run on Windows, Node.js has to be checked out from
GitHub with the `autocrlf` git config flag set to true.

## Test Directories

|Directory |Runs on CI |Purpose |
Expand Down

0 comments on commit c1fe9b2

Please sign in to comment.