From cb7f73c9d4885488d335f2afaa5e0c4ec8b8b758 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Thu, 17 Dec 2020 05:35:24 -0800 Subject: [PATCH] tools: revise line in configure.py for clarity * Replace unused identifier with Python convention `_`. * Remove unneeded parentheses. * Remove line-wrapping. I confirmed that this doesn't change the output by running `./configure --shared-zlib` and confirming that it created the same `common.gypi` with and without these changes. The code changed here doesn't run unless there is a `--shared-*` flag. PR-URL: https://github.com/nodejs/node/pull/36551 Reviewed-By: Richard Lau Reviewed-By: Antoine du Hamel Reviewed-By: Luigi Pinca Reviewed-By: Daijiro Wachi --- configure.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/configure.py b/configure.py index c24d56b5d1891d..8ed8524b26667e 100755 --- a/configure.py +++ b/configure.py @@ -1347,8 +1347,7 @@ def configure_library(lib, output, pkgname=None): output['variables']['node_' + shared_lib] = b(getattr(options, shared_lib)) if getattr(options, shared_lib): - (pkg_libs, pkg_cflags, pkg_libpath, pkg_modversion) = ( - pkg_config(pkgname or lib)) + (pkg_libs, pkg_cflags, pkg_libpath, _) = pkg_config(pkgname or lib) if options.__dict__[shared_lib + '_includes']: output['include_dirs'] += [options.__dict__[shared_lib + '_includes']]