From cd1aa2b0b5ebb693ba079c919bfb06b0eee5098d Mon Sep 17 00:00:00 2001 From: dominikeinkemmer Date: Sat, 24 Nov 2018 16:56:04 +0900 Subject: [PATCH] test: fix http2-binding strictEqual order MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Switched the order of arguments for strictEqual checks inside of test/paralell/test-http2-binding.js PR-URL: https://github.com/nodejs/node/pull/24616 Refs: https://github.com/nodejsjp/node-1/issues/1 Reviewed-By: Anna Henningsen Reviewed-By: Joyee Cheung Reviewed-By: Colin Ihrig Reviewed-By: Michaël Zasso --- test/parallel/test-http2-binding.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/parallel/test-http2-binding.js b/test/parallel/test-http2-binding.js index 6991f98afd72d1..8c2826e5fb4b6e 100644 --- a/test/parallel/test-http2-binding.js +++ b/test/parallel/test-http2-binding.js @@ -233,16 +233,16 @@ const defaultSettings = { for (const name of Object.keys(constants)) { if (name.startsWith('HTTP_STATUS_')) { - assert.strictEqual(expectedStatusCodes[name], constants[name], + assert.strictEqual(constants[name], expectedStatusCodes[name], `Expected status code match for ${name}`); } else if (name.startsWith('HTTP2_HEADER_')) { - assert.strictEqual(expectedHeaderNames[name], constants[name], + assert.strictEqual(constants[name], expectedHeaderNames[name], `Expected header name match for ${name}`); } else if (name.startsWith('NGHTTP2_')) { - assert.strictEqual(expectedNGConstants[name], constants[name], + assert.strictEqual(constants[name], expectedNGConstants[name], `Expected ng constant match for ${name}`); } else if (name.startsWith('DEFAULT_SETTINGS_')) { - assert.strictEqual(defaultSettings[name], constants[name], + assert.strictEqual(constants[name], defaultSettings[name], `Expected default setting match for ${name}`); } }