From cf5624c4d8f16397c6d12aaf13bcc3ecfe10b8fe Mon Sep 17 00:00:00 2001 From: Matheus Marchini Date: Tue, 14 Jan 2020 08:45:31 -0800 Subject: [PATCH] test: add promises metadata to postmortem test type_JSPromise__JS_PROMISE_TYPE and type_JSMessageObject__JS_MESSAGE_OBJECT_TYPE will be used on llnode to identify Promises in memory and core dumps: https://github.com/nodejs/llnode/pull/272. Add these to our postmortem test so we're aware of any changes to this metadata. PR-URL: https://github.com/nodejs/node/pull/31357 Reviewed-By: Colin Ihrig Reviewed-By: Rich Trott --- test/v8-updates/test-postmortem-metadata.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/v8-updates/test-postmortem-metadata.js b/test/v8-updates/test-postmortem-metadata.js index 0891e62251db87..79520f9f4bf802 100644 --- a/test/v8-updates/test-postmortem-metadata.js +++ b/test/v8-updates/test-postmortem-metadata.js @@ -161,7 +161,9 @@ function getExpectedSymbols() { 'v8dbg_type_JSFunction__JS_FUNCTION_TYPE', 'v8dbg_type_JSGlobalObject__JS_GLOBAL_OBJECT_TYPE', 'v8dbg_type_JSGlobalProxy__JS_GLOBAL_PROXY_TYPE', + 'v8dbg_type_JSMessageObject__JS_MESSAGE_OBJECT_TYPE', 'v8dbg_type_JSObject__JS_OBJECT_TYPE', + 'v8dbg_type_JSPromise__JS_PROMISE_TYPE', 'v8dbg_type_JSRegExp__JS_REG_EXP_TYPE', 'v8dbg_type_JSTypedArray__JS_TYPED_ARRAY_TYPE', 'v8dbg_type_Map__MAP_TYPE',