From cff2aea5df3d65caee17148891a7c751be7e5110 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Tue, 27 Jul 2021 19:10:42 -0700 Subject: [PATCH] test: add known issues test for debugger heap snapshot race MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Refs: https://github.com/nodejs/node/issues/39555 PR-URL: https://github.com/nodejs/node/pull/39557 Reviewed-By: James M Snell Reviewed-By: Michaƫl Zasso --- .../test-debugger-takeHeapSnapshot-race.js | 48 +++++++++++++++++++ 1 file changed, 48 insertions(+) create mode 100644 test/known_issues/test-debugger-takeHeapSnapshot-race.js diff --git a/test/known_issues/test-debugger-takeHeapSnapshot-race.js b/test/known_issues/test-debugger-takeHeapSnapshot-race.js new file mode 100644 index 00000000000000..c1974135046671 --- /dev/null +++ b/test/known_issues/test-debugger-takeHeapSnapshot-race.js @@ -0,0 +1,48 @@ +'use strict'; +const common = require('../common'); + +// Refs: https://github.com/nodejs/node/issues/39555 + +// After this issue is fixed, this can perhaps be integrated into +// test/sequential/test-debugger-heap-profiler.js as it shares almost all +// the same code. + +// These skips should be uncommented once the issue is fixed. +// common.skipIfInspectorDisabled(); + +// if (!common.isMainThread) { +// common.skip('process.chdir() is not available in workers'); +// } + +// This assert.fail() can be removed once the issue is fixed. +if (!common.hasCrypto || !process.features.inspector) { + require('assert').fail('crypto is not available'); +} + +const fixtures = require('../common/fixtures'); +const startCLI = require('../common/debugger'); +const tmpdir = require('../common/tmpdir'); + +tmpdir.refresh(); +process.chdir(tmpdir.path); + +const { readFileSync } = require('fs'); + +const filename = 'node.heapsnapshot'; + +// Check that two simultaneous snapshots don't step all over each other. +{ + const cli = startCLI([fixtures.path('debugger/empty.js')]); + + function onFatal(error) { + cli.quit(); + throw error; + } + + return cli.waitForInitialBreak() + .then(() => cli.waitForPrompt()) + .then(() => cli.command('takeHeapSnapshot(); takeHeapSnapshot()')) + .then(() => JSON.parse(readFileSync(filename, 'utf8'))) + .then(() => cli.quit()) + .then(null, onFatal); +}