From d1acc86f594c4c069fe045f18ef82bf08b2732a9 Mon Sep 17 00:00:00 2001 From: Chase Starr Date: Fri, 16 Dec 2016 17:28:59 -0800 Subject: [PATCH] doc: clarify macosx-firewall suggestion BUILDING `./tools/macosx-firewall.sh` fails if run before build step. Since the suggestion comes before the build steps in the document, this change clarifies that the script should be run after building. PR-URL: https://github.com/nodejs/node/pull/10311 Reviewed-By: Myles Borins Reviewed-By: Jeremiah Senkpiel Reviewed-By: Colin Ihrig Reviewed-By: Italo A. Casas Reviewed-By: Gibson Fahnestock Reviewed-By: James M Snell --- BUILDING.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/BUILDING.md b/BUILDING.md index b1962d53c2caf4..b98bb75d79b656 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -24,8 +24,8 @@ On OS X, you will also need: this under the menu `Xcode -> Preferences -> Downloads` * This step will install `gcc` and the related toolchain containing `make` -* You may want to setup [firewall rules](tools/macosx-firewall.sh) to avoid -popups asking to accept incoming network connections when running tests: +* After building, you may want to setup [firewall rules](tools/macosx-firewall.sh) +to avoid popups asking to accept incoming network connections when running tests: ```console $ sudo ./tools/macosx-firewall.sh