From d49e6693fe17dc42a1234682b0903c94fb594c23 Mon Sep 17 00:00:00 2001 From: Bradley Farias Date: Wed, 5 Jul 2017 17:22:43 -0500 Subject: [PATCH] url: do not use HandleScope in ToObject It is not needed / invalidates the returned value unlike EscapableHandleScope PR-URL: https://github.com/nodejs/node/pull/14096 Reviewed-By: Refael Ackermann Reviewed-By: Anna Henningsen Reviewed-By: Timothy Gu Reviewed-By: Colin Ihrig Reviewed-By: James M Snell --- src/node_url.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/src/node_url.cc b/src/node_url.cc index 2865f445e44606..c50700b2946831 100644 --- a/src/node_url.cc +++ b/src/node_url.cc @@ -2085,7 +2085,6 @@ static void DomainToUnicode(const FunctionCallbackInfo& args) { const Local URL::ToObject(Environment* env) const { Isolate* isolate = env->isolate(); Local context = env->context(); - HandleScope handle_scope(isolate); Context::Scope context_scope(context); const Local undef = Undefined(isolate);