Skip to content

Commit

Permalink
meta: document commit msg exception for long URLs
Browse files Browse the repository at this point in the history
PR-URL: #20207
Fixes: #17116
Refs: nodejs/core-validate-commit#24
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
  • Loading branch information
vsemozhetbyt authored and jasnell committed Apr 23, 2018
1 parent 51164dd commit d591a59
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion doc/guides/contributing/pull-requests.md
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ A good commit message should describe what changed and why.


2. Keep the second line blank.
3. Wrap all other lines at 72 columns.
3. Wrap all other lines at 72 columns (except for long URLs).

4. If your patch fixes an open issue, you can add a reference to it at the end
of the log. Use the `Fixes:` prefix and the full issue URL. For other references
Expand Down

0 comments on commit d591a59

Please sign in to comment.