From d68ee7eab74c10a7d9323e2c2e447911c7ab7118 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Fri, 2 Mar 2018 12:05:55 +0100 Subject: [PATCH] deps: cherry-pick 04a06c9 from upstream V8 Original commit message: [inspector] Make test byte order independent Change-Id: If0fdc76170ad29b4d3dadddbb32bc87c307c04af Reviewed-on: https://chromium-review.googlesource.com/881883 Reviewed-by: Aleksey Kozyatinskiy Commit-Queue: Eugene Ostroukhov Cr-Commit-Position: refs/heads/master@{#50817} Refs: https://github.com/v8/v8/commit/04a06c9e7ceafa50cfc4991d8f0e5dec888e275b PR-URL: https://github.com/nodejs/node/pull/18453 Reviewed-By: James M Snell Reviewed-By: Colin Ihrig Reviewed-By: Yang Guo Reviewed-By: Ali Ijaz Sheikh Reviewed-By: Michael Dawson --- common.gypi | 2 +- .../runtime/get-properties-expected.txt | 40 +++++++++---------- .../test/inspector/runtime/get-properties.js | 4 +- 3 files changed, 23 insertions(+), 23 deletions(-) diff --git a/common.gypi b/common.gypi index 1687a0d3c941ba..9a9b5ec50820c3 100644 --- a/common.gypi +++ b/common.gypi @@ -27,7 +27,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.0', + 'v8_embedder_string': '-node.1', # Enable disassembler for `--print-code` v8 options 'v8_enable_disassembler': 1, diff --git a/deps/v8/test/inspector/runtime/get-properties-expected.txt b/deps/v8/test/inspector/runtime/get-properties-expected.txt index 340a51c4a58701..8b48e65c3b7060 100644 --- a/deps/v8/test/inspector/runtime/get-properties-expected.txt +++ b/deps/v8/test/inspector/runtime/get-properties-expected.txt @@ -54,33 +54,33 @@ Running test: testTypedArrayWithoutLength Running test: testArrayBuffer [[Int8Array]] 0 own number 1 - 1 own number 2 - 2 own number 3 - 3 own number 4 - 4 own number 5 - 5 own number 6 - 6 own number 7 - 7 own number 8 + 1 own number 1 + 2 own number 1 + 3 own number 1 + 4 own number 1 + 5 own number 1 + 6 own number 1 + 7 own number 1 __proto__ own object undefined [[Uint8Array]] 0 own number 1 - 1 own number 2 - 2 own number 3 - 3 own number 4 - 4 own number 5 - 5 own number 6 - 6 own number 7 - 7 own number 8 + 1 own number 1 + 2 own number 1 + 3 own number 1 + 4 own number 1 + 5 own number 1 + 6 own number 1 + 7 own number 1 __proto__ own object undefined [[Int16Array]] - 0 own number 513 - 1 own number 1027 - 2 own number 1541 - 3 own number 2055 + 0 own number 257 + 1 own number 257 + 2 own number 257 + 3 own number 257 __proto__ own object undefined [[Int32Array]] - 0 own number 67305985 - 1 own number 134678021 + 0 own number 16843009 + 1 own number 16843009 __proto__ own object undefined Running test: testArrayBufferWithBrokenUintCtor diff --git a/deps/v8/test/inspector/runtime/get-properties.js b/deps/v8/test/inspector/runtime/get-properties.js index d8132bb678e15f..d2b2c754a311e2 100644 --- a/deps/v8/test/inspector/runtime/get-properties.js +++ b/deps/v8/test/inspector/runtime/get-properties.js @@ -34,7 +34,7 @@ InspectorTest.runAsyncTestSuite([ }, async function testArrayBuffer() { - let objectId = await evaluateToObjectId('new Uint8Array([1, 2, 3, 4, 5, 6, 7, 8]).buffer'); + let objectId = await evaluateToObjectId('new Uint8Array([1, 1, 1, 1, 1, 1, 1, 1]).buffer'); let props = await Protocol.Runtime.getProperties({ objectId, ownProperties: true }); for (let prop of props.result.result) { if (prop.name === '__proto__') @@ -49,7 +49,7 @@ InspectorTest.runAsyncTestSuite([ this.uint8array_old = this.Uint8Array; this.Uint8Array = 42; })()`); - await logExpressionProperties('new Int8Array([1, 2, 3, 4, 5, 6, 7]).buffer'); + await logExpressionProperties('new Int8Array([1, 1, 1, 1, 1, 1, 1]).buffer'); await evaluateToObjectId(`(function() { this.Uint8Array = this.uint8array_old; delete this.uint8array_old;