Skip to content

Commit

Permalink
test: Use countdown in test file
Browse files Browse the repository at this point in the history
Fixes: #17169

PR-URL: #17646
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
  • Loading branch information
sreepurnajasti authored and MylesBorins committed Jan 9, 2018
1 parent 46f8a9e commit d9190c1
Showing 1 changed file with 6 additions and 19 deletions.
25 changes: 6 additions & 19 deletions test/parallel/test-http-pipeline-regr-3332.js
Original file line number Diff line number Diff line change
@@ -1,40 +1,27 @@
'use strict';
require('../common');
const assert = require('assert');
const http = require('http');
const net = require('net');
const Countdown = require('../common/countdown');

const big = Buffer.alloc(16 * 1024, 'A');

const COUNT = 1e4;

let received = 0;
const countdown = new Countdown(COUNT, () => {
server.close();
client.end();
});

let client;
const server = http.createServer(function(req, res) {
res.end(big, function() {
if (++received === COUNT) {
server.close();
client.end();
}
countdown.dec();
});
}).listen(0, function() {
const req = 'GET / HTTP/1.1\r\n\r\n'.repeat(COUNT);
client = net.connect(this.address().port, function() {
client.write(req);
});

// Just let the test terminate instead of hanging
client.on('close', function() {
if (received !== COUNT)
server.close();
});
client.resume();
});

process.on('exit', function() {
// The server should pause connection on pipeline flood, but it shoul still
// resume it and finish processing the requests, when its output queue will
// be empty again.
assert.strictEqual(received, COUNT);
});

0 comments on commit d9190c1

Please sign in to comment.