test: fix tap parser fails if a test logs a number

nodejs · Jan 8, 2023 · dba8a16 · dba8a16
1 parent 6766172
commit dba8a16
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 1 deletion.
diff --git a/lib/internal/test_runner/tap_parser.js b/lib/internal/test_runner/tap_parser.js
@@ -644,8 +644,16 @@ class TapParser extends Transform {
     }
 
     const planEnd = this.#next();
-    if (planEnd?.kind !== TokenKind.NUMERIC) {
+    if (!planEnd || planEnd.kind !== TokenKind.NUMERIC) {
       this.#error('Expected a plan end count');
+      const node = {
+        kind: TokenKind.UNKNOWN,
+        node: {
+          value: this.#currentChunkAsString,
+        },
+      };
+
+      return node;
     }
 
     const plan = {

diff --git a/test/parallel/test-runner-tap-parser-stream.js b/test/parallel/test-runner-tap-parser-stream.js
@@ -17,6 +17,28 @@ const cases = [
       },
     ],
   },
+  {
+    input: '123',
+    expected: [
+      {
+        kind: 'Unknown',
+        node: { value: '123' },
+        nesting: 0,
+        lexeme: '123',
+      },
+    ],
+  },
+  {
+    input: '# 123',
+    expected: [
+      {
+        kind: 'Comment',
+        node: { comment: '123' },
+        nesting: 0,
+        lexeme: '# 123',
+      },
+    ],
+  },
   {
     input: 'invalid tap',
     expected: [