tls: tweak clientCertEngine argument parsing

PR-URL: #38900 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs · Jun 4, 2021 · dc25378 · dc25378
1 parent fc4b9c1
commit dc25378
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/lib/internal/tls.js b/lib/internal/tls.js
@@ -305,15 +305,15 @@ function configSecureContext(context, options = {}, name = 'options') {
     }
   }
 
-  if (clientCertEngine !== undefined) {
+  if (typeof clientCertEngine === 'string') {
     if (typeof context.setClientCertEngine !== 'function')
       throw new ERR_CRYPTO_CUSTOM_ENGINE_NOT_SUPPORTED();
-    if (typeof clientCertEngine !== 'string') {
-      throw new ERR_INVALID_ARG_TYPE(`${name}.clientCertEngine`,
-                                     ['string', 'null', 'undefined'],
-                                     clientCertEngine);
-    }
-    context.setClientCertEngine(clientCertEngine);
+    else
+      context.setClientCertEngine(clientCertEngine);
+  } else if (clientCertEngine !== undefined) {
+    throw new ERR_INVALID_ARG_TYPE(`${name}.clientCertEngine`,
+                                   ['string', 'null', 'undefined'],
+                                   clientCertEngine);
   }
 
   if (ticketKeys !== undefined) {