From de86e1a5789476c1d6e643ba2ae31e1408101519 Mon Sep 17 00:00:00 2001
From: Rich Trott <rtrott@gmail.com>
Date: Tue, 11 Feb 2020 01:31:25 -1000
Subject: [PATCH] util: throw if unreachable TypedArray checking code is
 reached

If a comparison code path that is supposed to be unreachable is reached,
throw. Add a c8 comment to ignore coverage for the line, as it
should be unreachable.

PR-URL: https://github.com/nodejs/node/pull/31737
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
---
 lib/internal/util/comparisons.js | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/lib/internal/util/comparisons.js b/lib/internal/util/comparisons.js
index 222bb936722cb6..1598e7f9136ace 100644
--- a/lib/internal/util/comparisons.js
+++ b/lib/internal/util/comparisons.js
@@ -147,7 +147,11 @@ function isIdenticalTypedArrayType(a, b) {
       return check(b);
     }
   }
-  return false;
+  /* c8 ignore next */
+  assert.fail(
+    `Unknown TypedArray type checking ${a[SymbolToStringTag]} ${a}\n` +
+    `and ${b[SymbolToStringTag]} ${b}`
+  );
 }
 
 // Notes: Type tags are historical [[Class]] properties that can be set by