From e2aaee0ffd9a2450c208983c3aca09245a058958 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Sun, 10 Mar 2019 21:27:29 -0700 Subject: [PATCH] doc: edit "Using git-node" section of Guide Edit the "Using git-node" section of the Collaborator Guide. Make sentences concise and clear, reduce use of passive voice, etc. PR-URL: https://github.com/nodejs/node/pull/26580 Reviewed-By: Richard Lau Reviewed-By: Daniel Bevenius Reviewed-By: Masashi Hirano Reviewed-By: Colin Ihrig Reviewed-By: Vse Mozhet Byt Reviewed-By: Beth Griggs --- COLLABORATOR_GUIDE.md | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index 02a83ef736cf38..48f6cfee29edf3 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -419,9 +419,8 @@ tests. This makes it much easier when bisecting to find a breaking change. ### Using `git-node` In most cases, using [the `git-node` command][git-node] of [`node-core-utils`][] -should be enough to help you land a Pull Request. If you discover a problem when -using this tool, please file an issue -[to the issue tracker][node-core-utils-issues]. +should be enough to land a pull request. If you discover a problem when using +this tool, please file an issue [to the issue tracker][node-core-utils-issues]. Quick example: @@ -430,12 +429,11 @@ $ npm install -g node-core-utils $ git node land $PRID ``` -If it's the first time you have used `node-core-utils`, you will be prompted -to type the password of your GitHub account and the two-factor authentication -code in the console so the tool can create the GitHub access token for you. -If you do not want to do that, follow -[the `node-core-utils` guide][node-core-utils-credentials] -to set up your credentials manually. +To use `node-core-utils`, you will need a GitHub access token. If you do not +have one, `node-core-utils` will create one for you the first time you use it. +To do this, it will ask for your GitHub password and two-factor authentication +code. If you wish to create the token yourself in advance, see +[the `node-core-utils` guide][node-core-utils-credentials]. ### Technical HOWTO