From e2b10ff6fbb8883098633f0b19a740651f8fb55b Mon Sep 17 00:00:00 2001 From: Vse Mozhet Byt Date: Thu, 22 Nov 2018 00:38:05 +0200 Subject: [PATCH] doc,meta: update PR approving info Refs: https://github.com/nodejs/node/pull/22255 PR-URL: https://github.com/nodejs/node/pull/24561 Reviewed-By: Rich Trott Reviewed-By: Anatoli Papirovski --- doc/guides/contributing/pull-requests.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/guides/contributing/pull-requests.md b/doc/guides/contributing/pull-requests.md index cd2bc4d5ebdcb8..33c2872f534f97 100644 --- a/doc/guides/contributing/pull-requests.md +++ b/doc/guides/contributing/pull-requests.md @@ -416,7 +416,8 @@ unhelpful is likely safe to ignore. ### Step 10: Landing In order to land, a Pull Request needs to be reviewed and [approved][] by -at least one Node.js Collaborator and pass a +at least two Node.js Collaborators (one Collaborator approval is enough if the +pull request has been open for more than 7 days) and pass a [CI (Continuous Integration) test run][]. After that, as long as there are no objections from other contributors, the Pull Request can be merged. If you find your Pull Request waiting longer than you expect, see the