From e4224fd793bbab8cde2f3ea5e17cc5cef59721f2 Mon Sep 17 00:00:00 2001 From: Shivang Date: Fri, 25 May 2018 14:12:36 -0400 Subject: [PATCH] test: improve path tests Replaced deepStrictEqual with strictEqual when asserting that the path is equal to the win32 or posix equivalent, since it is a more strict check than deepStrictCheck. Also removed third argument in the check so that if there is an assertion error the properties that are different will be displayed. PR-URL: https://github.com/nodejs/node/pull/20967 Reviewed-By: Colin Ihrig Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca Reviewed-By: Ujjwal Sharma Reviewed-By: Ruben Bridgewater Reviewed-By: Trivikram Kamat Reviewed-By: James M Snell --- test/parallel/test-path.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/parallel/test-path.js b/test/parallel/test-path.js index a3f10eccdf1d7e..ca10665b26ffc1 100644 --- a/test/parallel/test-path.js +++ b/test/parallel/test-path.js @@ -68,6 +68,6 @@ assert.strictEqual(path.win32.delimiter, ';'); assert.strictEqual(path.posix.delimiter, ':'); if (common.isWindows) - assert.deepStrictEqual(path, path.win32, 'should be win32 path module'); + assert.strictEqual(path, path.win32); else - assert.deepStrictEqual(path, path.posix, 'should be posix path module'); + assert.strictEqual(path, path.posix);