diff --git a/src/node_process.cc b/src/node_process.cc index 6c12dcc02b2cd0..74b2b64f3458e1 100644 --- a/src/node_process.cc +++ b/src/node_process.cc @@ -730,40 +730,29 @@ void EnvDeleter(Local property, void EnvEnumerator(const PropertyCallbackInfo& info) { Environment* env = Environment::GetCurrent(info); Isolate* isolate = env->isolate(); - Local ctx = env->context(); - Local fn = env->push_values_to_array_function(); - Local argv[NODE_PUSH_VAL_TO_ARRAY_MAX]; - size_t idx = 0; Mutex::ScopedLock lock(environ_mutex); + Local envarr; + int env_size = 0; #ifdef __POSIX__ - int size = 0; - while (environ[size]) - size++; - - Local envarr = Array::New(isolate); + while (environ[env_size]) { + env_size++; + } + std::vector> env_v(env_size); - for (int i = 0; i < size; ++i) { + for (int i = 0; i < env_size; ++i) { const char* var = environ[i]; const char* s = strchr(var, '='); const int length = s ? s - var : strlen(var); - argv[idx] = String::NewFromUtf8(isolate, - var, - v8::NewStringType::kNormal, - length).ToLocalChecked(); - if (++idx >= arraysize(argv)) { - fn->Call(ctx, envarr, idx, argv).ToLocalChecked(); - idx = 0; - } - } - if (idx > 0) { - fn->Call(ctx, envarr, idx, argv).ToLocalChecked(); + env_v[i] = + String::NewFromUtf8(isolate, var, v8::NewStringType::kNormal, length) + .ToLocalChecked(); } #else // _WIN32 + std::vector> env_v; WCHAR* environment = GetEnvironmentStringsW(); if (environment == nullptr) return; // This should not happen. - Local envarr = Array::New(isolate); WCHAR* p = environment; while (*p) { WCHAR* s; @@ -789,19 +778,13 @@ void EnvEnumerator(const PropertyCallbackInfo& info) { FreeEnvironmentStringsW(environment); return; } - argv[idx] = rc.ToLocalChecked(); - if (++idx >= arraysize(argv)) { - fn->Call(ctx, envarr, idx, argv).ToLocalChecked(); - idx = 0; - } + env_v.push_back(rc.ToLocalChecked()); p = s + wcslen(s) + 1; } - if (idx > 0) { - fn->Call(ctx, envarr, idx, argv).ToLocalChecked(); - } FreeEnvironmentStringsW(environment); #endif + envarr = Array::New(isolate, env_v.data(), env_v.size()); info.GetReturnValue().Set(envarr); } diff --git a/test/parallel/test-process-env.js b/test/parallel/test-process-env.js index 60f4d6f4faf13b..51cc637d06e5c4 100644 --- a/test/parallel/test-process-env.js +++ b/test/parallel/test-process-env.js @@ -91,6 +91,7 @@ assert.strictEqual(5, date.getHours()); // case-sensitive on other platforms. process.env.TEST = 'test'; assert.strictEqual(process.env.TEST, 'test'); + // Check both mixed case and lower case, to avoid any regressions that might // simply convert input to lower case. if (common.isWindows) { @@ -100,3 +101,8 @@ if (common.isWindows) { assert.strictEqual(process.env.test, undefined); assert.strictEqual(process.env.teST, undefined); } + +{ + const keys = Object.keys(process.env); + assert.ok(keys.length > 0); +}