From e93c94c3271ae2c0553856d047928156a7b51ba9 Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Wed, 26 Sep 2018 15:15:06 +0200 Subject: [PATCH] deps: add no-strict-aliasing to ICU cflags This commit adds -Wno-strict-aliasing to the icu_implementation target. The motivation for this is that this flags is enabled when building with macosx, and will make the output a little cleaner when building on other operating systems. PR-URL: https://github.com/nodejs/node/pull/23112 Reviewed-By: Anna Henningsen Reviewed-By: James M Snell --- tools/icu/icu-generic.gyp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/icu/icu-generic.gyp b/tools/icu/icu-generic.gyp index a50f12d7940bf7..f64981b6e6c0d5 100644 --- a/tools/icu/icu-generic.gyp +++ b/tools/icu/icu-generic.gyp @@ -52,7 +52,7 @@ 'direct_dependent_settings': { 'conditions': [ [ 'os_posix == 1 and OS != "mac" and OS != "ios"', { - 'cflags': [ '-Wno-deprecated-declarations' ], + 'cflags': [ '-Wno-deprecated-declarations', '-Wno-strict-aliasing' ], 'cflags_cc': [ '-frtti' ], 'cflags_cc!': [ '-fno-rtti' ], }],