From f6b005d82ce5216fdc73c6c2f13133dc531c8be3 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Tue, 27 Aug 2019 23:04:51 -0700 Subject: [PATCH] test: remove Windows skipping of http keepalive request GC test MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Remove code to skip Windows in test-http-server-keepalive-req-gc. The test now works reliably on Windows (I think). PR-URL: https://github.com/nodejs/node/pull/29354 Reviewed-By: Anna Henningsen Reviewed-By: Colin Ihrig Reviewed-By: Luigi Pinca Reviewed-By: James M Snell Reviewed-By: Richard Lau Reviewed-By: Сковорода Никита Андреевич Reviewed-By: David Carlier --- test/parallel/test-http-server-keepalive-req-gc.js | 5 ----- 1 file changed, 5 deletions(-) diff --git a/test/parallel/test-http-server-keepalive-req-gc.js b/test/parallel/test-http-server-keepalive-req-gc.js index 77defb5154676e..e94845d38df098 100644 --- a/test/parallel/test-http-server-keepalive-req-gc.js +++ b/test/parallel/test-http-server-keepalive-req-gc.js @@ -5,11 +5,6 @@ const onGC = require('../common/ongc'); const { createServer } = require('http'); const { connect } = require('net'); -if (common.isWindows) { - // TODO(addaleax): Investigate why and remove the skip. - common.skip('This test is flaky on Windows.'); -} - // Make sure that for HTTP keepalive requests, the req object can be // garbage collected once the request is finished. // Refs: https://github.com/nodejs/node/issues/9668