From f748f5df5688da5d5c2a759da2a85c8527c882c4 Mon Sep 17 00:00:00 2001 From: Daeyeon Jeong Date: Tue, 25 Oct 2022 03:17:19 +0900 Subject: [PATCH] src: remove unused `contextify_global_private_symbol` MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `contextify_global_private_symbol` is no longer used. It was used to hold a new context's global object, but the approach has been changed to hold a ContextifyContext wrapper using `contextify_context_private_symbol`. Signed-off-by: Daeyeon Jeong PR-URL: https://github.com/nodejs/node/pull/45128 Refs: https://github.com/nodejs/node/pull/44796 Reviewed-By: James M Snell Reviewed-By: Luigi Pinca Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Joyee Cheung Reviewed-By: Juan José Arboleda --- src/env_properties.h | 1 - typings/internalBinding/util.d.ts | 13 ++++++------- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/src/env_properties.h b/src/env_properties.h index fe065c172b3957..7b86a7325256d8 100644 --- a/src/env_properties.h +++ b/src/env_properties.h @@ -20,7 +20,6 @@ #define PER_ISOLATE_PRIVATE_SYMBOL_PROPERTIES(V) \ V(arrow_message_private_symbol, "node:arrowMessage") \ V(contextify_context_private_symbol, "node:contextify:context") \ - V(contextify_global_private_symbol, "node:contextify:global") \ V(decorated_private_symbol, "node:decorated") \ V(napi_type_tag, "node:napi:type_tag") \ V(napi_wrapper, "node:napi:wrapper") \ diff --git a/typings/internalBinding/util.d.ts b/typings/internalBinding/util.d.ts index 5045330dc1547c..002f8eb26d93e6 100644 --- a/typings/internalBinding/util.d.ts +++ b/typings/internalBinding/util.d.ts @@ -8,15 +8,14 @@ declare namespace InternalUtilBinding { } declare function InternalBinding(binding: 'util'): { - // PER_ISOLATE_PRIVATE_SYMBOL_PROPERTIES, defined in src/env.h + // PER_ISOLATE_PRIVATE_SYMBOL_PROPERTIES, defined in src/env_properties.h arrow_message_private_symbol: 1; contextify_context_private_symbol: 2; - contextify_global_private_symbol: 3; - decorated_private_symbol: 4; - napi_type_tag: 5; - napi_wrapper: 6; - untransferable_object_private_symbol: 7; - exiting_aliased_Uint32Array: 8; + decorated_private_symbol: 3; + napi_type_tag: 4; + napi_wrapper: 5; + untransferable_object_private_symbol: 6; + exiting_aliased_Uint32Array: 7; kPending: 0; kFulfilled: 1;