From fcf3781d22259cb7b30f285bcd09cb984407bf20 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Juan=20Jos=C3=A9=20Arboleda?= <soyjuanarbol@gmail.com>
Date: Fri, 7 Jul 2023 12:01:17 -0500
Subject: [PATCH] lib,src,test: lint codebase according new rules for v18.x
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/48697
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
---
 lib/internal/fs/promises.js        | 8 --------
 lib/internal/modules/esm/loader.js | 1 -
 pyproject.toml                     | 1 +
 src/node_builtins.cc               | 7 ++++---
 test/common/wpt.js                 | 2 --
 5 files changed, 5 insertions(+), 14 deletions(-)

diff --git a/lib/internal/fs/promises.js b/lib/internal/fs/promises.js
index 6e348c89b792ef..bd3e15e4db83fb 100644
--- a/lib/internal/fs/promises.js
+++ b/lib/internal/fs/promises.js
@@ -110,14 +110,6 @@ const {
   JSTransferable, kDeserialize, kTransfer, kTransferList,
 } = require('internal/worker/js_transferable');
 
-const {
-  newReadableStreamFromStreamBase,
-} = require('internal/webstreams/adapters');
-
-const {
-  readableStreamCancel,
-} = require('internal/webstreams/readablestream');
-
 const getDirectoryEntriesPromise = promisify(getDirents);
 const validateRmOptionsPromise = promisify(validateRmOptions);
 
diff --git a/lib/internal/modules/esm/loader.js b/lib/internal/modules/esm/loader.js
index d2a3647e3c2168..ace05721405365 100644
--- a/lib/internal/modules/esm/loader.js
+++ b/lib/internal/modules/esm/loader.js
@@ -549,7 +549,6 @@ class ESMLoader {
    * until it reaches the bottom or short-circuits.
    * @param {URL['href']} url The URL/path of the module to be loaded
    * @param {object} context Metadata about the module
-   *
    * @returns {{ format: ModuleFormat, source: ModuleSource }}
    */
   async load(url, context = {}) {
diff --git a/pyproject.toml b/pyproject.toml
index 6b51197ad66c2e..4c791d96654ea1 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -28,6 +28,7 @@ ignore = [
   "PLC1901",
   "RUF005",
   "RUF100",
+  "RUF012",
 ]
 line-length = 172
 target-version = "py37"
diff --git a/src/node_builtins.cc b/src/node_builtins.cc
index 65970ffc33ae68..2220869fa76f35 100644
--- a/src/node_builtins.cc
+++ b/src/node_builtins.cc
@@ -365,9 +365,10 @@ MaybeLocal<Function> BuiltinLoader::LookupAndCompileInternal(
   return scope.Escape(fun);
 }
 
-MaybeLocal<Function> BuiltinLoader::LookupAndCompile(Local<Context> context,
-                                                     const char* id,
-                                                     Environment* optional_env) {
+MaybeLocal<Function> BuiltinLoader::LookupAndCompile(
+    Local<Context> context,
+    const char* id,
+    Environment* optional_env) {
   Result result;
   std::vector<Local<String>> parameters;
   Isolate* isolate = context->GetIsolate();
diff --git a/test/common/wpt.js b/test/common/wpt.js
index 74cf2327da8a49..c1054ad5f0e130 100644
--- a/test/common/wpt.js
+++ b/test/common/wpt.js
@@ -715,7 +715,6 @@ class WPTRunner {
   /**
    * Report the status of each specific test case (there could be multiple
    * in one test file).
-   *
    * @param {string} filename
    * @param {Test} test  The Test object returned by WPT harness
    */
@@ -735,7 +734,6 @@ class WPTRunner {
 
   /**
    * Report the status of each WPT test (one per file)
-   *
    * @param {string} filename
    * @param {object} harnessStatus - The status object returned by WPT harness.
    */