Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm@2.7.4 fails to install private git repository dependencies #1323

Closed
imyller opened this issue Apr 2, 2015 · 4 comments
Closed

npm@2.7.4 fails to install private git repository dependencies #1323

imyller opened this issue Apr 2, 2015 · 4 comments
Labels
confirmed-bug Issues with confirmed bugs.

Comments

@imyller
Copy link
Member

imyller commented Apr 2, 2015

npm 2.7.4 included with io.js 1.6.3 fails to install dependencies from private git repositories such as:

"private": "git+ssh://git@github.com:org/private"

Error:

npm ERR! Cannot read property 'charAt' of undefined 

For more information see npm/npm#7807

@Fishrock123
Copy link
Contributor

Noted, thanks. We'll try to get a 1.6.4 out when npm is updated with the fix here.

@Fishrock123 Fishrock123 added the confirmed-bug Issues with confirmed bugs. label Apr 2, 2015
@Fishrock123 Fishrock123 changed the title npm fails to install private git repository dependencies npm@2.7.4 fails to install private git repository dependencies Apr 2, 2015
@othiym23
Copy link
Contributor

othiym23 commented Apr 3, 2015

npm@2.7.5 has a fix for this, but comes with an ugly and misleading error message when cloning private GitHub repositories. npm@2.7.6 has all the fixes, but should probably be allowed to bake for a week so people have a chance to make sure that I've finally gotten all the git cheese-moving complete and correct. I'm really sorry for all this churn around git, and all I can say is that this is part of a long-term investment to make npm's git integration more consistent and robust, at the cost of some short-term pain.

@Fishrock123
Copy link
Contributor

@imyller If you have time, could apply #1337 to help verify?

https://github.com/iojs/io.js/pull/1337.patch

@Fishrock123
Copy link
Contributor

Fixed in v1.6.4 as of 5eb983e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed-bug Issues with confirmed bugs.
Projects
None yet
Development

No branches or pull requests

3 participants