Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

entry for inspector in onboarding-extras.md #13621

Closed
Trott opened this issue Jun 11, 2017 · 4 comments
Closed

entry for inspector in onboarding-extras.md #13621

Trott opened this issue Jun 11, 2017 · 4 comments
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. meta Issues and PRs related to the general management of the project.

Comments

@Trott
Copy link
Member

Trott commented Jun 11, 2017 •
edited
Loading

  • Version: master
  • Platform: all
  • Subsystem: doc

We should have an entry in onboarding-extras.md for who to /cc for inspector issues. Who should be in it? Is it @eugeneo or @nodejs/diagnostics or what?
@Trott Trott added doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. labels Jun 11, 2017
@addaleax
Copy link
Member

I’d suggest we create a team with @eugeneo and maybe @bnoordhuis and/or @ofrobots that people are free to join if they like?

@gibfahn
Copy link
Member

gibfahn commented Jun 11, 2017

You mean like @nodejs/v8-inspector 😜 ?

@gibfahn
Copy link
Member

gibfahn commented Jun 11, 2017

For anyone picking this up, you'd want to add the v8-inspector team to doc/onboarding-extras.md#who-to-cc-in-issues.

@mscdex mscdex added the meta Issues and PRs related to the general management of the project. label Jun 12, 2017
@mscdex mscdex changed the title entry for inspector in onboarding-extras.ms entry for inspector in onboarding-extras.md Jun 12, 2017
@thelostone-mc
Copy link
Contributor

Calling dibs if no one has picked it up yet !!

@thelostone-mc thelostone-mc mentioned this issue Jun 12, 2017
Closed
2 tasks
thelostone-mc added a commit to thelostone-mc/node that referenced this issue Jun 13, 2017
@thelostone-mc
doc: updated /cc list for inspector issues
c3fbe02 
Updated onboarding-extras.md to /cc @nodejs/v8-inspector
for inspector issues.

Fixes: nodejs#13621
thelostone-mc added a commit to thelostone-mc/node that referenced this issue Jun 13, 2017
@thelostone-mc
doc: reorganized /cc list in alphabetical order
44f2752 
reorganized /cc list in alphabetical order in
onboarding-extras.md

Refs: nodejs#13621
addaleax pushed a commit that referenced this issue Jun 17, 2017
@thelostone-mc @addaleax
doc: sort and update /cc list for inspector issues
8c15827 
Updated onboarding-extras.md to /cc @nodejs/v8-inspector for inspector
issues and reorganized /cc list in alphabetical order.

PR-URL: #13632
Fixes: #13621
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
addaleax pushed a commit that referenced this issue Jun 21, 2017
@thelostone-mc @addaleax
doc: sort and update /cc list for inspector issues
f5f2a0e 
Updated onboarding-extras.md to /cc @nodejs/v8-inspector for inspector
issues and reorganized /cc list in alphabetical order.

PR-URL: #13632
Fixes: #13621
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: updated /cc list for inspector issues thelostone-mc/node
5 participants
@mscdex @Trott @addaleax @thelostone-mc @gibfahn