Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build error C4716: 'v8::ArrayBuffer::Allocator::Reserve': must return a value #13624

Closed
langxiong opened this issue Jun 11, 2017 · 2 comments
Closed
Labels
duplicate Issues and PRs that are duplicates of other issues or PRs.

Comments

@langxiong
Copy link

langxiong commented Jun 11, 2017

  • Version: node-v8.1.0
  • Platform: Windows-10
  • Subsystem: x64

Build node.js from source, with command:

.\vcbuild.bat debug x64 vs2015

got a error:

c:\users\x5831\node\node-v8.1.0\deps\v8\src\api.cc(440): error C4716: 'v8::ArrayBuffer::Allocator::Reserve': must retur
n a value [C:\Users\x5831\node\node-v8.1.0\deps\v8\src\v8_base_1.vcxproj]

And I check the source code, 'api.cc'.

void* v8::ArrayBuffer::Allocator::Reserve(size_t length) { UNIMPLEMENTED(); }

Solved this by add a return nullptr;

void* v8::ArrayBuffer::Allocator::Reserve(size_t length) { UNIMPLEMENTED();  return nullptr;}
@refack
Copy link
Contributor

refack commented Jun 12, 2017

@langxiong thank for the report. AFAIK C4716 is a warning. Do you have anywhere a directive to treat warnings as errors?

@mscdex mscdex added node-api Issues and PRs related to the Node-API. c++ Issues and PRs that require attention from people who are familiar with C++. v8 engine Issues and PRs related to the V8 dependency. build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. and removed node-api Issues and PRs related to the Node-API. labels Jun 12, 2017
@TimothyGu TimothyGu added duplicate Issues and PRs that are duplicates of other issues or PRs. and removed build Issues and PRs related to build files or the CI. c++ Issues and PRs that require attention from people who are familiar with C++. v8 engine Issues and PRs related to the V8 dependency. windows Issues and PRs related to the Windows platform. labels Jun 12, 2017
@TimothyGu
Copy link
Member

Duplicate of #13392.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Issues and PRs that are duplicates of other issues or PRs.
Projects
None yet
Development

No branches or pull requests

4 participants