Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: typo in async_hooks documentation #13663

Closed
mscdex opened this issue Jun 13, 2017 · 0 comments
Closed

doc: typo in async_hooks documentation #13663

mscdex opened this issue Jun 13, 2017 · 0 comments
Labels
async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to the documentations.

Comments

@mscdex
Copy link
Contributor

mscdex commented Jun 13, 2017

  • Version: master
  • Platform: n/a
  • Subsystem: doc

In the async_hooks docs there is a typo in the description for init()'s type:

Generally it will correspond the name of the resource's constructor.

The word 'with' should probably be inserted after 'correspond.'
@mscdex mscdex added async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. labels Jun 13, 2017
@chris--young chris--young mentioned this issue Jun 13, 2017
Closed
2 tasks
@mscdex mscdex removed the good first issue Issues that are suitable for first-time contributors. label Jun 13, 2017
chris--young pushed a commit to chris--young/node that referenced this issue Jun 13, 2017
doc: fixes a typo in the async_hooks documentation
dff842a 
> Generally it will correspond the name of the resource's constructor.
should read "will correspond with..."

Fixes: nodejs#13663
chris--young pushed a commit to chris--young/node that referenced this issue Jun 14, 2017
doc: fixes a typo in the async_hooks documentation
843cec3 
> Generally it will correspond the name of the resource's constructor.

should read "Generally, it will correspond to the name..."

Fixes: nodejs#13663
addaleax pushed a commit that referenced this issue Jun 17, 2017
@addaleax
doc: fixes a typo in the async_hooks documentation
4c98308 
> Generally it will correspond the name of the resource's constructor.
should read "Generally, it will correspond to the name..."

PR-URL: #13666
Fixes: #13663
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
addaleax pushed a commit that referenced this issue Jun 21, 2017
@addaleax
doc: fixes a typo in the async_hooks documentation
f28dd8e 
> Generally it will correspond the name of the resource's constructor.
should read "Generally, it will correspond to the name..."

PR-URL: #13666
Fixes: #13663
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: fixes a typo in the async_hooks documentation chris--young/node
1 participant
@mscdex