Windows intermittent ? - parallel/test-timers-throw-reschedule

[mhdawson]

• Version: v8.x-staging
• Platform: Windows
• Subsystem: timer

https://ci.nodejs.org/job/node-test-binary-windows/17851/COMPILED_BY=vs2015-x86,RUNNER=win2012r2,RUN_SUBSET=2/console

not ok 387 parallel/test-timers-throw-reschedule
  ---
  duration_ms: 0.400
  severity: fail
  stack: |-
    assert.js:42
      throw new errors.AssertionError({
      ^
    
    AssertionError [ERR_ASSERTION]: false == true
        at Timeout.common.mustCall (c:\workspace\node-test-binary-windows\test\parallel\test-timers-throw-reschedule.js:20:5)
        at Timeout._onTimeout (c:\workspace\node-test-binary-windows\test\common\index.js:478:15)
        at ontimeout (timers.js:498:11)
        at Timer.unrefdHandle (timers.js:611:5)
  ...

[apapirovski]

That test probably shouldn't be in parallel tbh. If someone wants to open a PR to move it to sequential on v8.x then that would be great.

[maclover7]

This is failing now on linuxone on v8.x:

06:03:31 not ok 1555 parallel/test-timers-throw-reschedule
06:03:31   ---
06:03:31   duration_ms: 0.366
06:03:31   severity: fail
06:03:31   stack: |-
06:03:31     assert.js:42
06:03:31       throw new errors.AssertionError({
06:03:31       ^
06:03:31     
06:03:31     AssertionError [ERR_ASSERTION]: false == true
06:03:31         at Timeout.common.mustCall (/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/parallel/test-timers-throw-reschedule.js:20:5)
06:03:31         at Timeout._onTimeout (/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/common/index.js:478:15)
06:03:31         at ontimeout (timers.js:498:11)
06:03:31         at Timer.unrefdHandle (timers.js:611:5)
06:03:31   ...

[MylesBorins]

Attempted to move to sequential and still feeing failures on linuxon

17:04:45 not ok 2153 sequential/test-timers-throw-reschedule
17:04:45   ---
17:04:45   duration_ms: 0.213
17:04:45   severity: fail
17:04:45   exitcode: 1
17:04:45   stack: |-
17:04:45     assert.js:42
17:04:45       throw new errors.AssertionError({
17:04:45       ^
17:04:45     
17:04:45     AssertionError [ERR_ASSERTION]: false == true
17:04:45         at Timeout.common.mustCall (/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/sequential/test-timers-throw-reschedule.js:20:5)
17:04:45         at Timeout._onTimeout (/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/common/index.js:478:15)
17:04:45         at ontimeout (timers.js:498:11)
17:04:45         at Timer.unrefdHandle (timers.js:611:5)
17:04:45   ...

https://ci.nodejs.org/job/node-test-commit-linuxone/4061/nodes=rhel72-s390x/console

/cc @nodejs/timers can someone please help out with this? Potentially blocking release

Edit: I've got a PR moving the test to sequential and marking it flaky... #22379

we should not close this issue until we figure out how to unflake the test

[MylesBorins]

this is showing up again in #23774

have no clue why it is not showing up as flaky

[BridgeAR]

Node.js v8.x has reached the end-of-life and won't receive any fixes anymore. I am closing this since this issue seems to only apply to Node.js v8.x.