-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: make parallel/test-bootstrap-modules
easier to reason about
#23884
Labels
flaky-test
Issues and PRs related to the tests with unstable failures on the CI.
process
Issues and PRs related to the process subsystem.
test
Issues and PRs related to the tests.
Comments
refack
added
good first issue
Issues that are suitable for first-time contributors.
test
Issues and PRs related to the tests.
flaky-test
Issues and PRs related to the tests with unstable failures on the CI.
process
Issues and PRs related to the process subsystem.
labels
Oct 25, 2018
4 tasks
fwiw my suggestion is now a whitelist of modules |
Can I work on this as this has a good first issue tag? @refack |
Trott
removed
good first issue
Issues that are suitable for first-time contributors.
mentor-available
labels
Nov 10, 2018
I kind of wonder if the test should be removed. |
3 tasks
richardlau
added a commit
to richardlau/node-1
that referenced
this issue
Mar 13, 2019
Be explicit on the modules that are expected to be loaded and add an appropriate assertion failure message to help debug when the list changes. Fixes: nodejs#23884 PR-URL: nodejs#26531 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
targos
pushed a commit
to targos/node
that referenced
this issue
Mar 27, 2019
Be explicit on the modules that are expected to be loaded and add an appropriate assertion failure message to help debug when the list changes. Fixes: nodejs#23884 PR-URL: nodejs#26531 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
flaky-test
Issues and PRs related to the tests with unstable failures on the CI.
process
Issues and PRs related to the process subsystem.
test
Issues and PRs related to the tests.
node/test/parallel/test-bootstrap-modules.js
Lines 1 to 14 in 5468509
The test uses a magic number that can only be reasonably found empeericaly. That number also changes depending on what CLI parameters are used, or if run with a test harness.
Some suggestions for improvement have been:
Refs: #23876
The text was updated successfully, but these errors were encountered: