-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
createConnection option not work for https module #24543
Comments
@nodejs/http Seems like a legit bug in the |
@leeight , thanks. |
I thinks it's because |
In `_tls_wrap.js` while calling `socket.connect` the `localPort` was missing, restore it. Fix: nodejs#24543
@cjihrig creatConnection is useful for opening a custom socket. Can this feature be added for HTTPS? Or is there a way to customize socket for HTTPS? Thanks! |
@eecs441staff does |
@cjihrig It worked! Thanks. |
Sounds to me like this can be closed, but comment and/or re-open if I've misunderstood. |
In `_tls_wrap.js` while calling `socket.connect` the `localPort` was missing, restore it. PR-URL: nodejs#24554 Fixes: nodejs#24543 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
In `_tls_wrap.js` while calling `socket.connect` the `localPort` was missing, restore it. PR-URL: nodejs#24554 Fixes: nodejs#24543 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Version: v10.13.0
Platform: Linux 4.15.0-39-generic x86_64
I am trying to use the createConnection option in the https module to set the client local port (localPort=34567 in the example below), but this only works when port = 80, not when port = 443. Following is the code I used to test. Does it mean that https module cannot set a custom socket for https in this way? Thanks.
The text was updated successfully, but these errors were encountered: