configure,icu: downgrade patch warning to info? #26346
Comments
bnoordhuis
added
build
bnoordhuis
added a commit
to bnoordhuis/io.js
that referenced
this issue
Feb 28, 2019
Downgrade the 'Using floating patch' message that is emitted when a local patch is applied to the bundled ICU from a warning to a notice. There isn't anything the user can or should do so warning isn't appropriate. Instead of angry yellow use soothing green. Fixes: nodejs#26346
|
Yes info or notice is fine.
Will be opening a PR for the next version soon which won't have any patches
(at least not initially!)
…On Wed, Feb 27, 2019, 10:50 PM Ben Noordhuis ***@***.***> wrote:
At today's ToT:
$ ./configure
WARNING: Using floating patch "tools/icu/patches/63/source/tools/toolutil/pkg_genc.cpp" from "tools/icu"
WARNING: warnings were emitted in the configure phase
I don't think WARNING is appropriate here as there isn't anything
actionable. INFO or NOTICE seems more appropriate. Agree/disagree?
cc @srl295 <https://github.com/srl295>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#26346>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA0MsxBim-4aPMqkPNi6ibg2-B5Om0X0ks5vR3xCgaJpZM4bWIPV>
.
|
addaleax
pushed a commit
that referenced
this issue
Mar 2, 2019
Downgrade the 'Using floating patch' message that is emitted when a local patch is applied to the bundled ICU from a warning to a notice. There isn't anything the user can or should do so warning isn't appropriate. Instead of angry yellow use soothing green. Fixes: #26346 PR-URL: #26349 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
At today's ToT:
I don't think WARNING is appropriate here as there isn't anything actionable. INFO or NOTICE seems more appropriate. Agree/disagree?
cc @srl295
The text was updated successfully, but these errors were encountered: