Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intl.DateTimeFormat(...).resolvedOptions() always return 'short' in timeZoneName #26790

Closed
vitvad opened this issue Mar 20, 2019 · 7 comments
Closed
Assignees
Labels
i18n-api Issues and PRs related to the i18n implementation. v8 engine Issues and PRs related to the V8 dependency.

Comments

@vitvad
Copy link

vitvad commented Mar 20, 2019

Version: tested for 9.21 and 11.60
Platform: OSX Mojave x86_64

tested with ICU v: '63.1', and without.

quick step to reproduce:

var region1 = new Intl.DateTimeFormat('en-US', { timeZoneName: 'long' });
console.log(`'${region1.resolvedOptions().timeZoneName}' should be equal to 'long'`);

will always return 'short'.

Chrome v72.0 - show's correct value
you can check it quickly in sandbox at MDN
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/DateTimeFormat

@sam-github
Copy link
Contributor

@nodejs/intl

@TimothyGu
Copy link
Member

Could you try installing full-icu as documented here?

@TimothyGu TimothyGu added question Issues that look for answers. i18n-api Issues and PRs related to the i18n implementation. labels Mar 20, 2019
@srl295
Copy link
Member

srl295 commented Mar 20, 2019

^ not repro in all versions, may be something that was fixed in v8

@srl295 srl295 self-assigned this Mar 20, 2019
@srl295 srl295 added the assert Issues and PRs related to the assert subsystem. label Mar 20, 2019
@srl295
Copy link
Member

srl295 commented Mar 20, 2019

working fine in 42dbaed

@srl295
Copy link
Member

srl295 commented Mar 20, 2019

was fixed in 9b4bf7d #23423 "update V8 to 7.1.302.28"

@srl295 srl295 closed this as completed Mar 20, 2019
@srl295 srl295 added v8 engine Issues and PRs related to the V8 dependency. and removed question Issues that look for answers. assert Issues and PRs related to the assert subsystem. labels Mar 20, 2019
@vitvad
Copy link
Author

vitvad commented Mar 20, 2019

@srl295 Thank you for quick response.
I just checked node v11.12.0 and it has v8 version v8: '7.0.276.38-node.18',
could you please clarify when node build with new v8 will be available ? As I see in ticket above, original plan was - Dec 2018.
As I understand it appear in node v12 around 2019-04-23 ?

@srl295
Copy link
Member

srl295 commented Mar 20, 2019

@vitvad Welcome. I'm not quite sure how to answer your question. You could ask on PR #23423 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n-api Issues and PRs related to the i18n implementation. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

No branches or pull requests

4 participants