--disallow-code-generation-from-strings doesn't work with NODE_OPTIONS

[milutin-apostol]

Hello.

Working: node --disallow-code-generation-from-strings index.js
Not working: NODE_OPTIONS=--disallow-code-generation-from-strings node index.js

Im getting error: node: --disallow-code-generation-from-strings is not allowed in NODE_OPTIONS

So its not possible to set --disallow-code-generation-from-strings in NODE_OPTIONS var.

Is this by design?

Thank you.

[sam-github]

Yes, its documented: https://nodejs.org/api/cli.html#cli_node_path_path (look above that link at the list, there is no direct link)

And perhaps no.... we have to explicitly whitelist v8 options we want to allow, see PerIsolateOptionsParser::PerIsolateOptionsParser in src/node_options.cc

Consider PRing a change to allow this one, it seems reasonable to me.

[codebytere]

I might grab this one if that's cool, it seems fairly straightforward :)

[codebytere]

Closed in #30094.