-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI is unusable #31955
Comments
cc @Trott @nodejs/build |
Browsing through some of these I'm not seeing a pattern that pertains to our build infra. Unless you can hone in on a particular infra issue, it's on you all to give our infra better code so we don't have so many flaky failures. |
I am going through some of the failures and triaging those. |
@gireeshpunathil I would suggest not going through build failures in node-test-pull-request, failures are expected on PRs (code fails), so its hard to detangle expected vs unexpected failures. I suggest you look at https://ci.nodejs.org/job/node-daily-master/ -- those builds all come from master, therefore every failure there is either a failure in infrastructure, or a flaky test. nodejs/node-core-utils#379 can be helpful in analysis. output
|
apologies all, half of my triages went erroneous. Everyday something new to learn, so! |
Perma-yellow at this time is to due to node-test-commit-osx, specifically the new osx1015. Given that we have lots of macOS users as Collaborators, I'm hopeful that someone can dig deep on those failures and get that working reliably. @nodejs/platform-macos |
@Trott we are waiting on Apple to fix their regression to lift us out of perma yellow - #30030 (comment) |
I still think that case should be skipped, perhaps actual js code (since it doesn't need to be skipped for all OS X versions). Our CI shouldn't be yellow if Apple, at their discretion, no longer ship a mostly unused network stack feature (kq notification of zero-length udp packets). It should be yellow if we have a bug. |
There's precedence for this too. We definitely used to have code in a test that skipped if it detected it was on macOS at a certain version. We took it out when Apple fixed the bug. I agree with Sam that an OS bug that causes a test to fail all the time should be skipped. (Even better if a second nearly-identical test is added to |
Which test(s) should be skipped on osx1015? |
The ones marked flaky here - https://github.com/nodejs/node/pull/31936/files would need backporting too to at least 12 (some are missing on 10 so its not as affected IIRC) |
FWIW the last few PRs I landed I had to run CI a few times before getting a green/yellow, so the problem is not limited to the OS X 10.15 issue. |
As of right now, the highest failure rate is on node-test-commit-linux-containered. |
Given that we have the flaky test project board and there really hasn't been updates on this in a while, closing. Can reopen if necessary. |
Latest build history:
The text was updated successfully, but these errors were encountered: