Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document http.OutgoingMessage #33847

Closed
rexagod opened this issue Jun 11, 2020 · 23 comments
Closed

document http.OutgoingMessage #33847

rexagod opened this issue Jun 11, 2020 · 23 comments
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors.

Comments

@rexagod
Copy link
Member

rexagod commented Jun 11, 2020 •
edited
Loading

AFAIK There's no documentation available for http.OutgoingMessage. Any new contributor willing to work on this can refer http.IncomingMessage for some inspiration.
@rexagod rexagod added the doc Issues and PRs related to the documentations. label Jun 11, 2020
@rexagod rexagod changed the title document http.OutgoingMessage document http.OutgoingMessage [good first issue!] Jun 11, 2020
@ronag ronag added the good first issue Issues that are suitable for first-time contributors. label Jun 13, 2020
@ronag ronag changed the title document http.OutgoingMessage [good first issue!] document http.OutgoingMessage Jun 13, 2020
@matthenschke
Copy link

I'll work on it!

@matthenschke
Copy link

Do you know where I can find the js code for OutgoingMessage, and are there any dependencies I should look at before attempting to add this documentation?

@rexagod
Copy link
Member Author

rexagod commented Jun 15, 2020 •
edited
Loading

You'll find the code in lib/_http_outgoing.js. There are no dependencies to worry about. :)

@rexagod rexagod mentioned this issue Jun 20, 2020
Closed
4 tasks
@finhaa
Copy link

finhaa commented Jul 24, 2020

Hey! I would like to contribute with this if there is no one else already contributing.

@rexagod
Copy link
Member Author

rexagod commented Jul 24, 2020 •
edited
Loading

@matthenschke Are you working on this?

@finhaa In the meantime you can take a look at nodetodo to find something interesting to work on! :)

@matthenschke
Copy link

The task is all yours @finhaa ! :)

@balrajsingh9
Copy link

Hey I would like to take this up if available ✌️

@finhaa
Copy link

finhaa commented Jul 30, 2020

Hey @rexagod, I won't be able to work in that task on this week. Sorry about that.

@balrajsingh9 You can take this!

@balrajsingh9
Copy link

balrajsingh9 commented Jul 31, 2020 •
edited
Loading

I have set up the workspace, but I need a kickstart. Can someone please help me out here?

I see a PR already opened referencing this issue, may I go ahead and borrow what's already documented from there?

@rexagod
Copy link
Member Author

rexagod commented Jul 31, 2020 •
edited
Loading

@balrajsingh9 You are free to look around and include in your PR whatever seems fit for this issue, I think @matthenschke won't mind, although you can include their commits in your PR in case you are entirely basing your work off of theirs, that way they can get credit for their work. :)

@jamesurobertson
Copy link

jamesurobertson commented Aug 21, 2020 •
edited
Loading

I can work on this if nobody else is still. Are you working on it still @balrajsingh9 ?

@balrajsingh9
Copy link

@jamesurobertson I was busy in moving abroad and finishing up with my current job. Please give me a week(max). If I don't finish this, I'll ping here and you may pick up.

@Hamza-324
Copy link

Hey guys, has this been done on can I work on this?

@jamesurobertson
Copy link

@Hamza-324 I was giving @balrajsingh9 a few more days per his last response to work on it before I was going to take care of it.

Any updates @balrajsingh9 ?

@balrajsingh9
Copy link

@jamesurobertson Please go ahead. I was almost done, but settling in a new country is taking longer than it should.

Please take this up. 👍

@Hamza-324
Copy link

Okay @jamesurobertson, Best of luck with this (Y)

@mmarchini mmarchini mentioned this issue Sep 4, 2020
Closed
1 task
@abhinavjonnada82
Copy link

abhinavjonnada82 commented Oct 2, 2020 •
edited
Loading

Is this available? Would like to take a dig at this!

@rexagod
Copy link
Member Author

rexagod commented Oct 2, 2020

Ping @jamesurobertson.

@Ayzrian
Copy link

Ayzrian commented Nov 5, 2020

Any progress here?
If nobody works on this one, I can pick this one.

@Hamza-324
Copy link

waiting on @jamesurobertson, else can I take it ?

@rexagod
Copy link
Member Author

rexagod commented Nov 6, 2020

Go ahead, @Hamza-324!

@Ayzrian In the meantime you can take a look at nodetodo to find something interesting to work on! :)

@Hamza-324
Copy link

@rexagod I've setup the code locally. However I'm having difficulty understanding the code for documentation. Where can I get any help in this regard ?

@caleblallen caleblallen mentioned this issue Dec 8, 2020
Closed
4 tasks
@Ayase-252
Copy link
Member

Hi, I'm looking for an opportunity to contribute. I see this issue has not be active for a while.
Is anyone still working on it? If not, I can take it.

Ayase-252 added a commit to Ayase-252/node that referenced this issue Feb 7, 2021
@Ayase-252
doc: add document for http.OutgoingMessage
c79ba67 
OutgoingMessage is a very old feature which is exported
to public in http module dated to v0.1.x. But
it is not documented at all.

This commit adds document for http.OutgogingMessage.

Fixes: nodejs#33847
Ayase-252 added a commit to Ayase-252/node that referenced this issue Feb 7, 2021
@Ayase-252
doc: add document for http.OutgoingMessage
6641764 
OutgoingMessage is a very old feature which is exported
to public in http module dated to v0.1.x. But
it is not documented at all.

This commit adds document for http.OutgogingMessage.

Fixes: nodejs#33847
@Ayase-252 Ayase-252 mentioned this issue Feb 7, 2021
Closed
danielleadams pushed a commit that referenced this issue Mar 16, 2021
@Ayase-252 @danielleadams
doc: add document for http.OutgoingMessage
e5f7179 
OutgoingMessage is a very old feature which is exported
to public in http module dated to v0.1.x. But
it is not documented at all.

This commit adds document for http.OutgogingMessage.

Fixes: #33847

PR-URL: #37265
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos pushed a commit that referenced this issue May 30, 2021
@Ayase-252 @targos
doc: add document for http.OutgoingMessage
d162841 
OutgoingMessage is a very old feature which is exported
to public in http module dated to v0.1.x. But
it is not documented at all.

This commit adds document for http.OutgogingMessage.

Fixes: #33847

PR-URL: #37265
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos pushed a commit that referenced this issue Jun 5, 2021
@Ayase-252 @targos
doc: add document for http.OutgoingMessage
587c3dd 
OutgoingMessage is a very old feature which is exported
to public in http module dated to v0.1.x. But
it is not documented at all.

This commit adds document for http.OutgogingMessage.

Fixes: #33847

PR-URL: #37265
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos pushed a commit that referenced this issue Jun 11, 2021
@Ayase-252 @targos
doc: add document for http.OutgoingMessage
19e8ae4 
OutgoingMessage is a very old feature which is exported
to public in http module dated to v0.1.x. But
it is not documented at all.

This commit adds document for http.OutgogingMessage.

Fixes: #33847

PR-URL: #37265
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: add document for http.OutgoingMessage Ayase-252/node
10 participants
@ronag @Ayase-252 @Hamza-324 @jamesurobertson @matthenschke @abhinavjonnada82 @rexagod @balrajsingh9 @finhaa @Ayzrian