Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable OpenSSL 3.0 tests in test-crypto-dh-stateless.js #38216

Closed
danbev opened this issue Apr 12, 2021 · 0 comments
Closed

Enable OpenSSL 3.0 tests in test-crypto-dh-stateless.js #38216

danbev opened this issue Apr 12, 2021 · 0 comments
Assignees
@danbev
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. openssl Issues and PRs related to the OpenSSL dependency.

Comments

@danbev
Copy link
Contributor

danbev commented Apr 12, 2021

This issue is just to keep track of openssl/openssl#14823. Once it has been included in a release which we use we should enable the tests that were commented out in #38165.
@danbev danbev self-assigned this Apr 12, 2021
@richardlau richardlau added flaky-test Issues and PRs related to the tests with unstable failures on the CI. openssl Issues and PRs related to the OpenSSL dependency. labels Apr 12, 2021
danbev added a commit to danbev/node that referenced this issue Oct 28, 2021
@danbev
Revert "test: skip different params test for OpenSSL 3.x"
5b60d4d 
This reverts commit 269f513.

Fixes: nodejs#38216
@danbev danbev mentioned this issue Oct 28, 2021
Closed
danielleadams pushed a commit that referenced this issue Dec 13, 2021
@danbev @danielleadams
Revert "test: skip different params test for OpenSSL 3.x"
6ab2589 
This reverts commit 269f513.

Fixes: #38216

PR-URL: #40640
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this issue Dec 14, 2021
@danbev @danielleadams
Revert "test: skip different params test for OpenSSL 3.x"
943547a 
This reverts commit 269f513.

Fixes: #38216

PR-URL: #40640
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this issue Jan 31, 2022
@danbev @danielleadams
Revert "test: skip different params test for OpenSSL 3.x"
ece974e 
This reverts commit 269f513.

Fixes: #38216

PR-URL: #40640
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this issue Feb 1, 2022
@danbev @danielleadams
Revert "test: skip different params test for OpenSSL 3.x"
38fd30f 
This reverts commit 269f513.

Fixes: #38216

PR-URL: #40640
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danbev danbev

Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. openssl Issues and PRs related to the OpenSSL dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "test: skip different params test for OpenSSL 3.x" danbev/node
2 participants
@danbev @richardlau