-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
can not step in constructor, will will terminate node.exe #4307
Comments
I tried running the code in in 4.2.3, 5.0.0, 5.1.1 and 5.2.0 on Mac OS X (Yosemite). /* 4307.js */
class CA { constructor(p) { console.log(p) } }
class CB extends CA {
constructor(p) {
super(p)
}
}
var cb = null
cb = new CB(123) Running I experienced no issues in REPL on either version. Leaving this here for reference only |
@fl0w did you debug it? can you step in |
I can confirm the problem:
|
Can confirm the issue and it doesn't look like it's #4261. The stack trace seems to suggest a V8 bug.
|
@flyingcodes sorry, I misread original report. Already confirmed but I'll just complete my original response. v5.0.0, v5.1.1, v5.2.0 $ node -v
v5.2.0
$ node debug --use-strict 4307.js
< Debugger listening on port 5858
connecting to 127.0.0.1:5858 ... ok
break in 4307.js:10
8 }
9
>10 var cb = null
11 cb = new CB(123)
12
debug> n
break in 4307.js:11
9
10 var cb = null
>11 cb = new CB(123)
12
13 });
debug> s
program terminated v4.2.3 $ node -v
v4.2.3
$ node debug --use-strict 4307.js
< Debugger listening on port 5858
debug> . ok
break in 4307.js:1
> 1 'use strict'
2
3 class CA { constructor(p) { console.log(p) } }
debug> n
break in 4307.js:10
8 }
9
>10 var cb = null
11 cb = new CB(123)
12
debug> n
break in 4307.js:11
9
10 var cb = null
>11 cb = new CB(123)
12
13 });
debug> s
break in 4307.js:5
3 class CA { constructor(p) { console.log(p) } }
4 class CB extends CA {
> 5 constructor(p) {
6 super(p)
7 }
debug> bt
#0 4307.js:5:14
#1 4307.js:11:6
debug> |
After some more investigation it doesn't look like it's #4297 either; or at least, #4298 doesn't fix it. Here is a backtrace from a debug build.
|
@fl0w @targos @bnoordhuis
terminated when step in at line 17 |
This appears to be fixed in master. Perhaps there's a fix that can be backported? @ofrobots |
This seems to have been fixed in the V8 4.9 branch. The 20160302 nightly fails but the 20160307 nightly passes. I will see if I can identify the commit that fixed it. |
This was fixed by v8/v8@14ec485. We will also need follow-on fix v8/v8@fc4c551 for PowerPC support, and v8/v8@30d6a4d for x87. I am -0 on backporting this to |
Closing as this is fixed in |
i report the bug to Microsoft/vscode in microsoft/vscode#953. then, They reply the bug is caused by node.js.
[fixed fomatting - bnoordhuis]
The text was updated successfully, but these errors were encountered: