Remove buffer.get and buffer.set
#4587
Labels
buffer
Issues and PRs related to the buffer subsystem.
Comments
|
Another advantage of removing these is that they'll stop shadowing the underlying |
feross
changed the title
buffer.get and buffer.setbuffer.get and buffer.set
|
Can be removed whenever. It never gets in the way of anything, so I keep forgetting about them. Wouldn't even say it's a major change. Not documented and have been fully deprecated going on 3 years (as @feross mentioned). |
|
@trevnorris Okay, PR sent: #4594 |
scovetta
pushed a commit
to scovetta/node
that referenced
this issue
Apr 2, 2016
These have been deprecated since Apr 27, 2013, and the plan was to remove them in "node v0.13". buffer.get(index) is superseded by buffer[index]. buffer.set(index, value) is superseded by buffer[index] = value. These have never been documented at any point in node's history. PR-URL: nodejs#4594 Fixes: nodejs#4587 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Roman Reiss <me@silverwind.io>
bookercodes
pushed a commit
to coolaj86/node-bufferjs
that referenced
this issue
Jun 3, 2016
Buffer.get was depracted in 2013 [1] and removed entirely in Node 6 [2]. Closes #13. [1] nodejs/node#4587 [2] https://github.com/nodejs/node/wiki/Breaking-changes-between-v5-and-v6#buffer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
These have been deprecated since Apr 27, 2013, and the plan was to remove them in "node v0.13", according to the comments.
buffer.get(index)is superseded bybuffer[index].buffer.set(index, value)is superseded bybuffer[index] = value.I haven't seen these used in real code, ever. They also have never been documented at any point in node's history, according to the git commit history for
doc/api/buffer.markdown.I think it is safe to finally remove these.
Thoughts?
The text was updated successfully, but these errors were encountered: