-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v8::String::Value
is deprecated
#54417
Labels
deprecations
Issues and PRs related to deprecations.
v8 engine
Issues and PRs related to the V8 dependency.
Comments
Here are the places where we use it:
|
RedYetiDev
added
v8 engine
Issues and PRs related to the V8 dependency.
deprecations
Issues and PRs related to deprecations.
labels
Aug 17, 2024
RedYetiDev
added a commit
to RedYetiDev/node
that referenced
this issue
Oct 19, 2024
RedYetiDev
added a commit
to RedYetiDev/node
that referenced
this issue
Oct 19, 2024
Ceres6
pushed a commit
to Ceres6/node
that referenced
this issue
Oct 30, 2024
Fixes nodejs#54417 Ref: nodejs#55452 PR-URL: nodejs#55458 Refs: nodejs#55452 Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS
pushed a commit
that referenced
this issue
Nov 1, 2024
louwers
pushed a commit
to louwers/node
that referenced
this issue
Nov 2, 2024
Fixes nodejs#54417 Ref: nodejs#55452 PR-URL: nodejs#55458 Refs: nodejs#55452 Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this issue
Nov 21, 2024
Fixes nodejs#54417 Ref: nodejs#55452 PR-URL: nodejs#55458 Refs: nodejs#55452 Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
deprecations
Issues and PRs related to deprecations.
v8 engine
Issues and PRs related to the V8 dependency.
We should use
v8::String::ValueView
instead.Refs:
node/deps/v8/include/v8-primitive.h
Lines 549 to 553 in e4f61de
/cc @anonrig
The text was updated successfully, but these errors were encountered: