v6.x backport: promise: better stack traces for --trace-warnings #10378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Give better stack traces for `PromiseRejectionHandledWarning` and `UnhandledPromiseRejectionWarning`s. For `PromiseRejectionHandledWarning`, when it is likely that there is an `Error` object generated, it is created early to provide a proper stack trace. For `UnhandledPromiseRejectionWarning`, the stack trace of the underlying error object is used, if possible. Fixes: nodejs#9523 PR-URL: nodejs#9525 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
3 tasks
Fishrock123
approved these changes
Dec 21, 2016
jasnell
approved these changes
Dec 23, 2016
Member
Author
|
Landed in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #9525 to v6.x
Had to resolve a minor conflict in
lib/internal/process/promises.jsand remove the deprecation message from the test output.Given that there was some worrying about breakage in #9525, this can wait for a bit if that makes people feel more comfortable. Generally the reactions so far seem to be positive, though.
CI: https://ci.nodejs.org/job/node-test-commit/6764/
Give better stack traces for
PromiseRejectionHandledWarningand
UnhandledPromiseRejectionWarnings.For
PromiseRejectionHandledWarning, when it is likely that thereis an
Errorobject generated, it is created early to provide aproper stack trace.
For
UnhandledPromiseRejectionWarning, the stack trace of theunderlying error object is used, if possible.
Fixes: #9523
PR-URL: #9525