Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v6.x: backport test: fix test-buffer-slow #10459

Merged
merged 1 commit into from
Dec 26, 2016
Merged

v6.x: backport test: fix test-buffer-slow #10459

merged 1 commit into from
Dec 26, 2016

Conversation

targos
Copy link
Member

@targos targos commented Dec 26, 2016

Backport of #9809

@targos targos added buffer Issues and PRs related to the buffer subsystem. test Issues and PRs related to the tests. v6.x labels Dec 26, 2016
@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. v6.x labels Dec 26, 2016
addaleax
addaleax approved these changes Dec 26, 2016
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@targos
Copy link
Member Author

targos commented Dec 26, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/5587/

@targos
test: fix test-buffer-slow
70d3b80 
Fix incorrect use of string instead of RegExp in `throws` assertions.

PR-URL: nodejs#9809
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@targos
Copy link
Member Author

targos commented Dec 26, 2016

CI failed because I cherry-picked #10146 instead of #10149 before making the PR.
New CI: https://ci.nodejs.org/job/node-test-pull-request/5589/

@targos targos merged commit 70d3b80 into nodejs:v6.x-staging Dec 26, 2016
@targos targos deleted the backport-9809-v6.x branch December 26, 2016 14:38
@targos
Copy link
Member Author

targos commented Dec 26, 2016

landed in 70d3b80

@snyk-bot snyk-bot mentioned this pull request Apr 24, 2023
Open
@aliscco aliscco mentioned this pull request Apr 24, 2023
Open
This was referenced Apr 24, 2023
Open
Open
@aliscco aliscco mentioned this pull request Apr 24, 2023
Open
This was referenced Apr 25, 2023
Open
Open
Open
@aliscco aliscco mentioned this pull request Apr 26, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Apr 26, 2023
Open
@aliscco aliscco mentioned this pull request Apr 28, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Apr 28, 2023
Open
@aliscco aliscco mentioned this pull request Apr 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@targos @addaleax @nodejs-github-bot