Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: support OPENSSL_CONF again #11006

Merged
merged 2 commits into from
Feb 9, 2017
Merged

crypto: support OPENSSL_CONF again #11006

merged 2 commits into from
Feb 9, 2017

Commits on Feb 9, 2017

  1. src: add SafeGetenv() to internal API 

    Allow it to be used anywhere in src/ that env variables with security
implications are accessed.
    @sam-github
    sam-github committed Feb 9, 2017
    5 Configuration menu
    Copy the full SHA
    901e926 View commit details
    Browse the repository at this point in the history

  2. crypto: support OPENSSL_CONF again 

    A side-effect of https://github.com/nodejs/node-private/pull/82
was to remove support for OPENSSL_CONF, as well as removing the default
read of a configuration file on startup.

Partly revert this, allowing OPENSSL_CONF to be used to specify a
configuration file to read on startup, but do not read a file by
default.

If the --openssl-config command line option is provided, its value is
used, not the OPENSSL_CONF environment variable.

Fix: nodejs#10938
PR-URL: nodejs#11006
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @sam-github
    sam-github committed Feb 9, 2017
    Configuration menu
    Copy the full SHA
    59afa27 View commit details
    Browse the repository at this point in the history