Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: append Cookie header values with semicolon #11259

Merged
merged 2 commits into from
Mar 9, 2017
Merged

http: append Cookie header values with semicolon #11259

merged 2 commits into from
Mar 9, 2017
+133 −72

Commits on Mar 9, 2017

  1. http: append Cookie header values with semicolon 

    Previously, separate incoming Cookie headers would be concatenated
with a comma, which can cause confusion in userland code when it
comes to parsing the final Cookie header value. This commit
concatenates using a semicolon instead.

Fixes: nodejs#11256
PR-URL: nodejs#11259
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @mscdex
    mscdex committed Mar 9, 2017
    Configuration menu
    Copy the full SHA
    6b2cef6 View commit details
    Browse the repository at this point in the history

  2. http: concatenate outgoing Cookie headers 

    This commit enables automatic concatenation of multiple Cookie header
values with a semicolon, except when 2D header arrays are used.

Fixes: nodejs#11256
PR-URL: nodejs#11259
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @mscdex
    mscdex committed Mar 9, 2017
    Configuration menu
    Copy the full SHA
    d348077 View commit details
    Browse the repository at this point in the history