deps: upgrade npm to 4.5.0 #12480
Closed
deps: upgrade npm to 4.5.0 #12480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iarna
added
dont-land-on-v4.x
npm
nodejs-github-bot
added
the
npm
ghost
approved these changes
Apr 18, 2017
Just fyi, the new semver-major cutoff date for Node 8 is May 9th, and the target release date is May 30th. It sounds like that might just be doable? |
|
*Full Log* |
|
Edit: some modifications to the test shows it is indeed the same error. log |
|
@iarna Looks like there is some issue with this PR, the previous npm runs the tests fine for me on |
Fishrock123
added a commit
to Fishrock123/node
that referenced
this pull request
Apr 18, 2017
This test now prints out some child error output if the npm child proc fails, allowing us to debug easier. Refs: nodejs#12480
3 tasks
|
Great stuff on npm 5. Hopefully we'll get that added to Node.js whenever it's considered stable! |
|
|
|
ping @nodejs/npm |
|
Sorry about that, it seems something in the Node.js |
|
Thanks, landed in 0084260! |
Fishrock123
pushed a commit
that referenced
this pull request
Apr 25, 2017
PR-URL: #12480 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
|
Sorry, didn’t catch it, but like #12479 this should not have landed just yet, with node-gyp v3.6.0 in it … I’ve added all dont-land labels, including the one for v8.x for now |
|
@addaleax except for |
|
@refack yea, and if somebody wants to pull the dont-land labels, sure. my code is fixed now (thanks again! :)) 😄 Basically, people in the other thread seemed to agree with #12479 (comment) – I don’t feel too strongly either way, but I would like to avoid publishing Node versions with known regressions unless we have a sensible reason to do so. |
|
I'm ±0 |
|
node-gyp@3.6.1 is out, can someone put in a PR to npm for this pls? |
|
@rvagg I should be able to do that, thanks for doing the release! edit: npm/npm#16484 |
ghost
pushed a commit
to ayojs/ayo
that referenced
this pull request
Aug 30, 2017
This test now prints out some child error output if the npm child proc fails, allowing us to debug easier. PR-URL: nodejs/node#12490 Refs: nodejs/node#12480 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
ghost
pushed a commit
to ayojs/ayo
that referenced
this pull request
Aug 30, 2017
This test now prints out some child error output if the npm child proc fails, allowing us to debug easier. PR-URL: nodejs/node#12490 Refs: nodejs/node#12480 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
depsDescription of Changes
npm lsoutput to be complete. Previously the list was trimmed. Additionally deduplicated dependencies are now listed with a note that they were deduped.Also a bunch of bug fixes and minor performance improvements.
(FYI: npm@5 has just [this day] entered internal testing at npm. We should have it out to public testing in a week or two. It'll have a longer-than-usual public test period due to it's larger-than-usual changes. The biggest thing it brings is massive speed improvements, so we're pretty excited about it. [On the order of 160s in npm@4 and 30s in npm@5.])
Changelogs
v4.5.0v4.4.4v4.4.3v4.4.2v4.4.1v4.4.0v4.3.0r: @Fishrock123
r: @addaleax
r: @jasnell