From a8d7ea2eec2fa2e2bbdea6d1fa4d34118b9a5842 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Fri, 12 May 2017 17:01:13 -0700 Subject: [PATCH] test: track callback invocations Use `common.mustCall()` and `common.mustNotCall()` to check that callbacks are invoked the expected number of times in test-net-listen-shared-ports. --- .../test-net-listen-shared-ports.js | 26 ++++++++++--------- 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/test/sequential/test-net-listen-shared-ports.js b/test/sequential/test-net-listen-shared-ports.js index c16285278afffe..282380ad271778 100644 --- a/test/sequential/test-net-listen-shared-ports.js +++ b/test/sequential/test-net-listen-shared-ports.js @@ -28,19 +28,19 @@ const net = require('net'); if (cluster.isMaster) { const worker1 = cluster.fork(); - worker1.on('message', function(msg) { + worker1.on('message', common.mustCall(function(msg) { assert.strictEqual(msg, 'success'); const worker2 = cluster.fork(); - worker2.on('message', function(msg) { + worker2.on('message', common.mustCall(function(msg) { assert.strictEqual(msg, 'server2:EADDRINUSE'); worker1.kill(); worker2.kill(); - }); - }); + })); + })); } else { - const server1 = net.createServer(common.noop); - const server2 = net.createServer(common.noop); + const server1 = net.createServer(common.mustNotCall()); + const server2 = net.createServer(common.mustNotCall()); server1.on('error', function(err) { // no errors expected @@ -56,10 +56,12 @@ if (cluster.isMaster) { host: 'localhost', port: common.PORT, exclusive: false - }, function() { - server2.listen({port: common.PORT + 1, exclusive: true}, function() { - // the first worker should succeed - process.send('success'); - }); - }); + }, common.mustCall(function() { + server2.listen({port: common.PORT + 1, exclusive: true}, + common.mustCall(function() { + // the first worker should succeed + process.send('success'); + }) + ); + })); }