From 9a733007f42b2b8504164c860b0fc93732729039 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Sat, 3 Jun 2017 13:22:57 -0700 Subject: [PATCH] test: refactor test-dgram-oob-buffer * Change common.noop to common.mustNotCall() to verify callback is not invoked. * Add destructuring assignment for clarity. Yeah, clarity. That's why. --- test/parallel/test-dgram-oob-buffer.js | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/test/parallel/test-dgram-oob-buffer.js b/test/parallel/test-dgram-oob-buffer.js index 136d378bbb9a46..1e71815927baca 100644 --- a/test/parallel/test-dgram-oob-buffer.js +++ b/test/parallel/test-dgram-oob-buffer.js @@ -31,14 +31,14 @@ const socket = dgram.createSocket('udp4'); const buf = Buffer.from([1, 2, 3, 4]); const portGetter = dgram.createSocket('udp4') .bind(0, 'localhost', common.mustCall(() => { - const address = portGetter.address(); + const { address, port } = portGetter.address(); portGetter.close(common.mustCall(() => { - socket.send(buf, 0, 0, address.port, address.address, common.noop); - socket.send(buf, 0, 4, address.port, address.address, common.noop); - socket.send(buf, 1, 3, address.port, address.address, common.noop); - socket.send(buf, 3, 1, address.port, address.address, common.noop); + socket.send(buf, 0, 0, port, address, common.mustNotCall()); + socket.send(buf, 0, 4, port, address, common.mustNotCall()); + socket.send(buf, 1, 3, port, address, common.mustNotCall()); + socket.send(buf, 3, 1, port, address, common.mustNotCall()); // Since length of zero means nothing, don't error despite OOB. - socket.send(buf, 4, 0, address.port, address.address, common.noop); + socket.send(buf, 4, 0, port, address, common.mustNotCall()); socket.close(); }));