doc: update minimum g++ version to 4.9.4 #13466

bnoordhuis · 2017-06-05T08:59:45Z

The 4.8.x releases don't fully support C++11. Update the prerequisites
for node.js 8 so that we won't have to work around compiler bugs in the
future.

To be decided if we should also update the minimum clang version.
I believe clang 3.4.2 properly supports C++11 but am not 100% sure.

Refs: #11840

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

tniessen · 2017-06-05T09:01:57Z

Docs: "Clang 3.3 and later implement all of the ISO C++ 2011 standard." I did not try to build with clang 3.3/3.4.2 though.

gibfahn · 2017-06-05T09:05:22Z

Which number is the clang version here?

➜  ~ ❯ clang --version                                                                                                             ~
Apple LLVM version 8.1.0 (clang-802.0.42)
Target: x86_64-apple-darwin16.6.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin

 ~ $ clang --version
Apple LLVM version 6.1.0 (clang-602.0.53) (based on LLVM 3.6.0svn)
Target: x86_64-
apple-darwin14.0.0
Thread model: posix

bnoordhuis · 2017-06-05T09:13:28Z

There is only a tenuous correspondence between apple-clang's version numbers and upstream clang. For OS X, we should just say "latest xcode (or xcode command line tools) or bust."

tniessen · 2017-06-05T09:13:49Z

@gibfahn LLVM 3.6.0svn should be the LLVM / clang version for your second snippet. No idea regarding the first one, probably something newer.

gibfahn · 2017-06-05T09:23:27Z

For OS X, we should just say "latest xcode (or xcode command line tools) or bust."

I guess the question is whether if you install the command line tools on an older macOS level you still get the latest version.

But in general that makes sense.

rvagg · 2017-06-05T09:40:52Z

We're still stuck on 4.8.2 for CentOS6/EL6, both test and release builds (have been for a while so I don't know why our stated minimum is newer than what we actually use). This comes out of devtoolset-2 from the scientificlinux repos. Any thoughts on how we go about getting a better gcc on EL6 without too much pain?

rvagg · 2017-06-05T09:56:51Z

devtoolset-3-gcc.x86_64 : GCC version 4.9
devtoolset-3-gcc-c++.x86_64 : C++ support for GCC version 4.9

Looks like we get devtoolset-3 on EL6 without anything special, so we could just switch to that instead of the hoops we jump through for devtoolset-2.

Does anyone know of any potentially breaking reasons that we might not want to switch from gcc 4.8 to gcc 4.9 for the Node.js 8 binaries that we ship? Would this be a disruption to users in any way?

gibfahn · 2017-06-05T10:39:50Z

Am I right in thinking that the libstdc++ dependency comes from gcc?

bnoordhuis · 2017-06-05T10:53:51Z

I guess the question is whether if you install the command line tools on an older macOS level you still get the latest version.

I think the answer is yes if it's a supported (by Apple) version of OS X / macOS.

Am I right in thinking that the libstdc++ dependency comes from gcc?

Correct. Per https://gcc.gnu.org/onlinedocs/libstdc++/manual/abi.html:

GCC 4.8.0: libstdc++.so.6.0.18
GCC 4.8.3: libstdc++.so.6.0.19
GCC 4.9.0: libstdc++.so.6.0.20

libstdc++6 releases are always forward-compatible and compatible with the previous one unless otherwise noted (which isn't the case for these three.)

gibfahn · 2017-06-05T11:16:41Z

libstdc++6 releases are always forward-compatible and compatible with the previous one unless otherwise noted (which isn't the case for these three.)

So these are all compatible, and there's no issue right (somewhat confused by the double negative)?

bnoordhuis · 2017-06-05T11:20:30Z

They are not incompatible, no. :-)

refack

Like 👍

refack · 2017-06-05T12:17:42Z

BUILDING.md

@@ -76,7 +76,7 @@ Depending on host platform, the selection of toolchains may vary.

 Prerequisites:

-* `gcc` and `g++` 4.8.5 or newer, or
+* `gcc` and `g++` 4.9.4 or newer, or
 * `clang` and `clang++` 3.4.2 or newer


How about adding a parenthetical (on macOS - latest xcode or xcode command line tools)

mhdawson

LGTM

seishun

Yes please. This is blocking #13676.

jasnell · 2017-06-14T16:51:08Z

@bnoordhuis ... I'd like to get this landed but @refack had an outstanding comment: #13466 (comment)

refack · 2017-06-14T17:20:55Z

@bnoordhuis ... I'd like to get this landed but @refack had an outstanding comment: #13466 (comment)

Non blocking suggestion.

The 4.8.x releases don't fully support C++11. Update the prerequisites for node.js 8 so that we won't have to work around compiler bugs in the future. To be decided if we should also update the minimum clang version. I believe clang 3.4.2 properly supports C++11 but am not 100% sure. Refs: nodejs#11840

bnoordhuis · 2017-06-15T12:05:33Z

Added note, PTAL.

Notable changes: * **Async Hooks** * Multiple improvements to Promise support in `async_hooks` have been made. * **Build** * The compiler version requirement to build Node with GCC has been raised to GCC 4.9.4. [[`23d41f3118`](2abaa86ba8)] [#13466](#13466) * **DNS** * The server used for DNS queries can now use a custom port. [[`2bb6614904`](8506acc1b5)] [#13723](#13723) * Support for `dns.resolveAny()` has been added. [[`30bc9dc20f`](30bc9dc20f)] [#13137](#13137) * **V8** * The V8 engine has been upgraded to version 5.9, which has a significantly changed performance profile. [#13515](#13515) PR-URL: #13744

The 4.8.x releases don't fully support C++11. Update the prerequisites for node.js 8 so that we won't have to work around compiler bugs in the future. To be decided if we should also update the minimum clang version. I believe clang 3.4.2 properly supports C++11 but am not 100% sure. PR-URL: #13466 Ref: #11840 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com>

Notable changes: * **Async Hooks** * Multiple improvements to Promise support in `async_hooks` have been made. * **Build** * The compiler version requirement to build Node with GCC has been raised to GCC 4.9.4. [[`23d41f3118`](2abaa86ba8)] [#13466](#13466) * **DNS** * The server used for DNS queries can now use a custom port. [[`2bb6614904`](8506acc1b5)] [#13723](#13723) * Support for `dns.resolveAny()` has been added. [[`30bc9dc20f`](30bc9dc20f)] [#13137](#13137) * **V8** * The V8 engine has been upgraded to version 5.9, which has a significantly changed performance profile. [#13515](#13515) PR-URL: #13744

The 4.8.x releases don't fully support C++11. Update the prerequisites for node.js 8 so that we won't have to work around compiler bugs in the future. To be decided if we should also update the minimum clang version. I believe clang 3.4.2 properly supports C++11 but am not 100% sure. PR-URL: #13466 Ref: #11840 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com>

Notable changes: * **Async Hooks** * Multiple improvements to Promise support in `async_hooks` have been made. * **Build** * The compiler version requirement to build Node with GCC has been raised to GCC 4.9.4. [[`23d41f3118`](2abaa86ba8)] [#13466](#13466) * **DNS** * The server used for DNS queries can now use a custom port. [[`2bb6614904`](8506acc1b5)] [#13723](#13723) * Support for `dns.resolveAny()` has been added. [[`30bc9dc20f`](30bc9dc20f)] [#13137](#13137) * **V8** * The V8 engine has been upgraded to version 5.9, which has a significantly changed performance profile. [#13515](#13515) PR-URL: #13744

Notable changes: * **Async Hooks** * Multiple improvements to Promise support in `async_hooks` have been made. * **Build** * The compiler version requirement to build Node with GCC has been raised to GCC 4.9.4. [[`820b011ed6`](820b011ed6)] [#13466](#13466) * **Cluster** * Users now have more fine-grained control over the inspector port used by individual cluster workers. Previously, cluster workers would simply increment from the master's debug port. [[`dfc46e262a`](dfc46e262a)] [#14140](#14140) * **DNS** * The server used for DNS queries can now use a custom port. [[`ebe7bb29aa`](ebe7bb29aa)] [#13723](#13723) * Support for `dns.resolveAny()` has been added. [[`6e30e2558e`](6e30e2558e)] [#13137](#13137) * **npm** * The `npm` CLI has been updated to version 5.3.0. In particular, it now comes with the `npx` binary, which is also shipped with Node. [[`dc3f6b9ac1`](dc3f6b9ac1)] [#14235](#14235) * `npm` Changelogs: - [v5.0.4](https://github.com/npm/npm/releases/tag/v5.0.4) - [v5.1.0](https://github.com/npm/npm/releases/tag/v5.1.0) - [v5.2.0](https://github.com/npm/npm/releases/tag/v5.2.0) - [v5.3.0](https://github.com/npm/npm/releases/tag/v5.3.0) PR-URL: #13744

@addaleax

Big thanks to @addaleax who prepared the vast majority of this release. Notable changes: * **Async Hooks** * Multiple improvements to Promise support in `async_hooks` have been made. * **Build** * The compiler version requirement to build Node with GCC has been raised to GCC 4.9.4. [[`820b011ed6`](nodejs@820b011ed6)] [nodejs#13466](nodejs#13466) * **Cluster** * Users now have more fine-grained control over the inspector port used by individual cluster workers. Previously, cluster workers would simply increment from the master's debug port. [[`dfc46e262a`](nodejs@dfc46e262a)] [nodejs#14140](nodejs#14140) * **DNS** * The server used for DNS queries can now use a custom port. [[`ebe7bb29aa`](nodejs@ebe7bb29aa)] [nodejs#13723](nodejs#13723) * Support for `dns.resolveAny()` has been added. [[`6e30e2558e`](nodejs@6e30e2558e)] [nodejs#13137](nodejs#13137) * **npm** * The `npm` CLI has been updated to version 5.3.0. In particular, it now comes with the `npx` binary, which is also shipped with Node. [[`dc3f6b9ac1`](nodejs@dc3f6b9ac1)] [nodejs#14235](nodejs#14235) * `npm` Changelogs: - [v5.0.4](https://github.com/npm/npm/releases/tag/v5.0.4) - [v5.1.0](https://github.com/npm/npm/releases/tag/v5.1.0) - [v5.2.0](https://github.com/npm/npm/releases/tag/v5.2.0) - [v5.3.0](https://github.com/npm/npm/releases/tag/v5.3.0) PR-URL: nodejs#13744

@addaleax

Big thanks to @addaleax who prepared the vast majority of this release. Notable changes: * **Async Hooks** * Multiple improvements to Promise support in `async_hooks` have been made. * **Build** * The compiler version requirement to build Node with GCC has been raised to GCC 4.9.4. [[`820b011ed6`](820b011ed6)] [#13466](#13466) * **Cluster** * Users now have more fine-grained control over the inspector port used by individual cluster workers. Previously, cluster workers would simply increment from the master's debug port. [[`dfc46e262a`](dfc46e262a)] [#14140](#14140) * **DNS** * The server used for DNS queries can now use a custom port. [[`ebe7bb29aa`](ebe7bb29aa)] [#13723](#13723) * Support for `dns.resolveAny()` has been added. [[`6e30e2558e`](6e30e2558e)] [#13137](#13137) * **npm** * The `npm` CLI has been updated to version 5.3.0. In particular, it now comes with the `npx` binary, which is also shipped with Node. [[`dc3f6b9ac1`](dc3f6b9ac1)] [#14235](#14235) * `npm` Changelogs: - [v5.0.4](https://github.com/npm/npm/releases/tag/v5.0.4) - [v5.1.0](https://github.com/npm/npm/releases/tag/v5.1.0) - [v5.2.0](https://github.com/npm/npm/releases/tag/v5.2.0) - [v5.3.0](https://github.com/npm/npm/releases/tag/v5.3.0) PR-URL: #13744

@addaleax

Big thanks to @addaleax who prepared the vast majority of this release. Notable changes: * **Async Hooks** * Multiple improvements to Promise support in `async_hooks` have been made. * **Build** * The compiler version requirement to build Node with GCC has been raised to GCC 4.9.4. [[`820b011ed6`](820b011ed6)] [#13466](#13466) * **Cluster** * Users now have more fine-grained control over the inspector port used by individual cluster workers. Previously, cluster workers would simply increment from the master's debug port. [[`dfc46e262a`](dfc46e262a)] [#14140](#14140) * **DNS** * The server used for DNS queries can now use a custom port. [[`ebe7bb29aa`](ebe7bb29aa)] [#13723](#13723) * Support for `dns.resolveAny()` has been added. [[`6e30e2558e`](6e30e2558e)] [#13137](#13137) * **npm** * The `npm` CLI has been updated to version 5.3.0. In particular, it now comes with the `npx` binary, which is also shipped with Node. [[`dc3f6b9ac1`](dc3f6b9ac1)] [#14235](#14235) * `npm` Changelogs: - [v5.0.4](https://github.com/npm/npm/releases/tag/v5.0.4) - [v5.1.0](https://github.com/npm/npm/releases/tag/v5.1.0) - [v5.2.0](https://github.com/npm/npm/releases/tag/v5.2.0) - [v5.3.0](https://github.com/npm/npm/releases/tag/v5.3.0) PR-URL: #13744

chrislea · 2017-07-25T21:52:36Z

I've got an unhealthy amount of info in my head about what Linux distros will be affected by this change and in what ways, so I thought I'd try and summarize that info here for people to see. As expected only older distros are affected, sometimes in different ways. Some are "easy to fix", which I define as "there is an easily installable new compiler toolchain available that doesn't cause any other issues when installed". I'll go from least problematic to most.

NO ISSUES

All supported version of Fedora
Debian Stretch, Buster, Sid
Ubuntu Xenial, Zappus

EASY TO DEAL WITH

CentOS 6 / CentOS 7 / RHEL6 / RHEL7 via devtoolset-6
Ubuntu Trusty for Intel Chips via clang-3.5

UNSURE HOW TO DEAL WITH BUT FEEL OKAY IGNORING

Debian Wheezy
Ubuntu Trusty for ARM Chips (can't compile openssl with clang on ARM)

ACTUAL PROBLEM PRACTICALLY SPEAKING

Debian Jessie

Jessie is a special case for a few reasons.

Tons of people run it
Most Raspberry Pi boards are running Raspbian which is Jessie

Now, Jessie ships with gcc = 4.9.2. So if any release from the 4.9.x series will work and we don't actually need exactly 4.9.4, then this is a non-issue. But, if we really do need 4.9.4, then this is a real issue that will affect a lot of people that I think will have a reasonable expectation that they can run the most up-to-date versions of Node.

Obviously let me know if there's any additional questions or info I can provide.

bnoordhuis · 2017-07-26T09:13:19Z

@chrislea Useful info, thanks.

As to the gcc version, 4.9.2 should work (and will probably continue to work) but I didn't want to get in a situation like we did with clang, where we had to float an intrusive patch to work around a bug in 3.4.1 that was fixed in 3.4.2.

refack · 2017-07-26T14:33:29Z

@chrislea et al. Will it give us more wiggle room, if we build each dep with a different toolset? (If that's possible and not harmful)?
I think I can break GYPs spirit and make it support that...
Ref: Should we continue to support FreeBSD? #14384

AdamMajer · 2017-07-31T10:30:04Z

FYI, default compiler for SLES12 is still gcc 4.8.5 although gcc6 is also available. SLE11SP4 only seems to have 5.3.1 available, with default gcc being 4.3

chrislea · 2017-07-31T17:02:31Z

Okay, thanks for the replies.

@bnoordhuis I think based on your comment that we're probably safe to assume 4.9.2 is "okay" for now. I will look into seeing if I can make 4.9.4 packages for Jessie to get around the potential issue that you mention that we saw with clang, but it's probably not too likely we'll see that.

@refack I'm not entirely sure what you're asking. We (NodeSource) currently build distro packages with toolsets native to each distro, so we're already using different toolsets and have been forever.

refack · 2017-07-31T17:48:19Z

I'm not entirely sure what you're asking. We (NodeSource) currently build distro packages with toolsets native to each distro, so we're already using different toolsets and have been forever.

I mean decompose the build, for example, build openSSL with gcc, V8 with clang, and tie them together with cc...

guillaume-lin · 2017-12-03T07:47:09Z

I am using cent os 7 and gcc 4.8.2, when compile node 8.9.1, it just warn me but not stop me from compile node. does this mean it is safe for me to compile node 8.9.1 with gcc 4.8.2 ?

tniessen · 2017-12-03T12:38:36Z

@guillaume-lin Just because something is not officially supported does not mean it is impossible, it just means that if you have any problems with your builds, you are on your own and most likely won't receive any support from us. Note that even if you manage to compile node using an outdated (and unsupported) compiler, this is no guarantee for the correctness, quality and / or performance of the resulting binary. We strongly recommend to use an up-to-date toolchain to compile node.

bnoordhuis added dont-land-on-v4.x labels Jun 5, 2017

nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Jun 5, 2017

gibfahn approved these changes Jun 5, 2017

View reviewed changes

tniessen approved these changes Jun 5, 2017

View reviewed changes

refack approved these changes Jun 5, 2017

View reviewed changes

jasnell approved these changes Jun 5, 2017

View reviewed changes

mhdawson approved these changes Jun 6, 2017

View reviewed changes

cjihrig approved these changes Jun 6, 2017

View reviewed changes

seishun approved these changes Jun 14, 2017

View reviewed changes

seishun mentioned this pull request Jun 14, 2017

src: replace macro with lambda #13676

Closed

2 tasks

bnoordhuis added 2 commits June 15, 2017 12:01

squash! add CLT note

6ab0f75

bnoordhuis force-pushed the update-gcc-prereq-8 branch from a378c66 to 6ab0f75 Compare June 15, 2017 12:04

nschonni mentioned this pull request Jul 19, 2017

Update Node to 8.2.0 nodejs/docker-node#469

Merged

bnoordhuis deleted the update-gcc-prereq-8 branch July 26, 2017 09:13

seishun mentioned this pull request Aug 31, 2017

ansible: use gcc 4.9 on Ubuntu 14.04 nodejs/build#797

Closed

refack mentioned this pull request Dec 1, 2017

Fix up Compiler levels for PPC machines nodejs/build#1020

Closed

richardlau mentioned this pull request Feb 15, 2019

Missing symbol running v10 on s390x #25774

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

doc: update minimum g++ version to 4.9.4 #13466

doc: update minimum g++ version to 4.9.4 #13466

bnoordhuis commented Jun 5, 2017

tniessen commented Jun 5, 2017 •

edited

Loading

gibfahn commented Jun 5, 2017

bnoordhuis commented Jun 5, 2017

tniessen commented Jun 5, 2017

gibfahn commented Jun 5, 2017 •

edited

Loading

rvagg commented Jun 5, 2017

rvagg commented Jun 5, 2017

gibfahn commented Jun 5, 2017

bnoordhuis commented Jun 5, 2017

gibfahn commented Jun 5, 2017

bnoordhuis commented Jun 5, 2017

refack left a comment

refack Jun 5, 2017

mhdawson left a comment

seishun left a comment

jasnell commented Jun 14, 2017

refack commented Jun 14, 2017

bnoordhuis commented Jun 15, 2017

chrislea commented Jul 25, 2017 •

edited

Loading

bnoordhuis commented Jul 26, 2017

refack commented Jul 26, 2017

AdamMajer commented Jul 31, 2017

chrislea commented Jul 31, 2017

refack commented Jul 31, 2017

guillaume-lin commented Dec 3, 2017

tniessen commented Dec 3, 2017

doc: update minimum g++ version to 4.9.4 #13466

doc: update minimum g++ version to 4.9.4 #13466

Conversation

bnoordhuis commented Jun 5, 2017

Checklist

Affected core subsystem(s)

tniessen commented Jun 5, 2017 • edited Loading

gibfahn commented Jun 5, 2017

bnoordhuis commented Jun 5, 2017

tniessen commented Jun 5, 2017

gibfahn commented Jun 5, 2017 • edited Loading

rvagg commented Jun 5, 2017

rvagg commented Jun 5, 2017

gibfahn commented Jun 5, 2017

bnoordhuis commented Jun 5, 2017

gibfahn commented Jun 5, 2017

bnoordhuis commented Jun 5, 2017

refack left a comment

Choose a reason for hiding this comment

refack Jun 5, 2017

Choose a reason for hiding this comment

mhdawson left a comment

Choose a reason for hiding this comment

seishun left a comment

Choose a reason for hiding this comment

jasnell commented Jun 14, 2017

refack commented Jun 14, 2017

bnoordhuis commented Jun 15, 2017

chrislea commented Jul 25, 2017 • edited Loading

bnoordhuis commented Jul 26, 2017

refack commented Jul 26, 2017

AdamMajer commented Jul 31, 2017

chrislea commented Jul 31, 2017

refack commented Jul 31, 2017

guillaume-lin commented Dec 3, 2017

tniessen commented Dec 3, 2017

tniessen commented Jun 5, 2017 •

edited

Loading

gibfahn commented Jun 5, 2017 •

edited

Loading

chrislea commented Jul 25, 2017 •

edited

Loading