Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix common.expectsError type checking #13686

Closed
wants to merge 3 commits into from
Closed

fix common.expectsError type checking #13686

wants to merge 3 commits into from

Commits on Dec 29, 2017

  1. test: fix wrong error classes passed in as type

    @BridgeAR
    BridgeAR committed Dec 29, 2017
    Configuration menu
    Copy the full SHA
    f8b8966 View commit details
    Browse the repository at this point in the history

  2. test: fix common.expectsError 

    The function should strictly test for the error class and only accept
the correct one. Any other error class should fail.
    @refack @BridgeAR
    refack authored and BridgeAR committed Dec 29, 2017
    Configuration menu
    Copy the full SHA
    adebaeb View commit details
    Browse the repository at this point in the history

  3. test: add more asserts to test-internal-errors

    @refack @BridgeAR
    refack authored and BridgeAR committed Dec 29, 2017
    Configuration menu
    Copy the full SHA
    c0606e0 View commit details
    Browse the repository at this point in the history