doc: fix padding mode of crypto.publicDecrypt #14036
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
crypto
vsemozhetbyt
reviewed
Jul 2, 2017
doc/api/crypto.md
Outdated
| @@ -1644,7 +1644,7 @@ added: v1.1.0 | |||
| - `passphrase` {string} An optional passphrase for the private key. | |||
| - `padding` {crypto.constants} An optional padding value defined in | |||
| `crypto.constants`, which may be: `crypto.constants.RSA_NO_PADDING`, | |||
There was a problem hiding this comment.
Are : and , still needed now?
There was a problem hiding this comment.
can be same as crypto.privateEncrypt?
MoonBall
force-pushed
the
fix-crypto-api-doc
branch
from
edb9552
to
4d47c2f
Compare
|
@vsemozhetbyt fixed >.< be same as |
vsemozhetbyt
approved these changes
Jul 2, 2017
cjihrig
approved these changes
Jul 2, 2017
tniessen
approved these changes
Jul 2, 2017
lpinca
approved these changes
Jul 2, 2017
|
Landed in 996a62e. Thank you for your contribution! 🎉 |
tniessen
pushed a commit
that referenced
this pull request
Jul 4, 2017
PR-URL: #14036 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Jul 11, 2017
PR-URL: #14036 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Merged
addaleax
pushed a commit
that referenced
this pull request
Jul 18, 2017
PR-URL: #14036 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Fishrock123
pushed a commit
that referenced
this pull request
Jul 19, 2017
PR-URL: #14036 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix padding mode of crypto.publicDecrypt.
crypto.publicDecrypt does not support
RSA_PKCS1_OAEP_PADDINGpadding mode.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc, crypto