From 6143a60127e1356bd24c50ae140bbbd3eb71f208 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Tue, 11 Jul 2017 21:45:17 -0700 Subject: [PATCH 1/2] test: reduce test-benchmark-net run duration Set configuration option to reduce combinations of benchmark settings tried in test, reducing execution time by about 50%. --- test/sequential/test-benchmark-net.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/test/sequential/test-benchmark-net.js b/test/sequential/test-benchmark-net.js index 826d891fd76621..ee5c6457d9460f 100644 --- a/test/sequential/test-benchmark-net.js +++ b/test/sequential/test-benchmark-net.js @@ -15,7 +15,10 @@ const path = require('path'); const runjs = path.join(__dirname, '..', '..', 'benchmark', 'run.js'); -const child = fork(runjs, ['--set', 'dur=0', 'net'], +const child = fork(runjs, + ['--set', 'dur=0', + '--set', 'type=buf', + 'net'], {env: {NODEJS_BENCHMARK_ZERO_ALLOWED: 1}}); child.on('exit', (code, signal) => { assert.strictEqual(code, 0); From 5c91befd53e82912c3a2a478bff4faa859b04301 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Tue, 11 Jul 2017 22:29:18 -0700 Subject: [PATCH 2/2] squash: additional improvements --- test/sequential/test-benchmark-net.js | 1 + 1 file changed, 1 insertion(+) diff --git a/test/sequential/test-benchmark-net.js b/test/sequential/test-benchmark-net.js index ee5c6457d9460f..ef5f4fbb91c760 100644 --- a/test/sequential/test-benchmark-net.js +++ b/test/sequential/test-benchmark-net.js @@ -17,6 +17,7 @@ const runjs = path.join(__dirname, '..', '..', 'benchmark', 'run.js'); const child = fork(runjs, ['--set', 'dur=0', + '--set', 'len=1024', '--set', 'type=buf', 'net'], {env: {NODEJS_BENCHMARK_ZERO_ALLOWED: 1}});