Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8.2.1 proposal #14399

Merged
merged 4 commits into from
Jul 20, 2017
Merged

8.2.1 proposal #14399

merged 4 commits into from
Jul 20, 2017

Conversation

Fishrock123
Copy link
Contributor

"Emergency" patch release. Today.

Primarily for #14387, but also including #14396 which didn't make it into 8.2.0.

@mcollina @Fishrock123
zlib: check if the stream is destroyed before push
6fce1a3 
If the stream is destroyed while the transform is still being
applied, push() should not be called, and the internal state
should be cleared.

Refs: koajs/compress#60
PR-URL: #14330
Backport-PR-URL: #14396
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

 Conflicts:
	lib/zlib.js
@Fishrock123 Fishrock123 added meta Issues and PRs related to the general management of the project. v8.x labels Jul 20, 2017
@Fishrock123 Fishrock123 self-assigned this Jul 20, 2017
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Jul 20, 2017
@Fishrock123 Fishrock123 changed the base branch from master to v8.x July 20, 2017 17:58
@Fishrock123 Fishrock123 removed build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Jul 20, 2017
@Fishrock123 Fishrock123 mentioned this pull request Jul 20, 2017
Closed
1 task
@mcollina @Fishrock123
process: triggerAsyncId can be undefined
302c19b 
Fixes: #14386
Fixes: #14381

PR-URL: #14387
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@mcollina @Fishrock123
http: do not abort if socket is missing
8d426bb 
Fixes: #14368

PR-URL: #14387
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
mscdex
mscdex reviewed Jul 20, 2017
View reviewed changes
doc/changelogs/CHANGELOG_V8.md Outdated
@@ -28,6 +29,17 @@
* [Archive](CHANGELOG_ARCHIVE.md)

<a id="8.2.0"></a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be updated.

@Fishrock123 Fishrock123 force-pushed the v8.2.1-proposal branch 2 times, most recently from 9fedddf to 191e812 Compare July 20, 2017 20:53
@Fishrock123
2017-07-20, Version 8.2.1 (Current)
7e46350 
Notable changes

* http: Writes no longer abort if the Socket is missing.
* process, async_hooks: Avoid problems when triggerAsyncId is undefined.
* zlib: Streams no longer attempt to process data when destroyed.

PR-URL: #14399
@Fishrock123
Copy link
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/9277/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/919/
Builds: https://ci-release.nodejs.org/job/iojs+release/1865/

@Fishrock123 Fishrock123 merged commit 7e46350 into v8.x Jul 20, 2017
Fishrock123 added a commit that referenced this pull request Jul 20, 2017
@Fishrock123
Working on v8.2.2
9e9e1b4 
PR-URL: #14399
Fishrock123 added a commit that referenced this pull request Jul 20, 2017
@Fishrock123
2017-07-20, Version 8.2.1 (Current)
6a5bdfb 
Notable changes

* http: Writes no longer abort if the Socket is missing.
* process, async_hooks: Avoid problems when triggerAsyncId is undefined.
* zlib: Streams no longer attempt to process data when destroyed.

PR-URL: #14399
Fishrock123 added a commit to nodejs/nodejs.org that referenced this pull request Jul 20, 2017
@Fishrock123
Blog: v8.2.1 release post
fcd0eb2 
PR-URL: nodejs/node#14399
@Fishrock123 Fishrock123 deleted the v8.2.1-proposal branch July 20, 2017 22:27
@Fishrock123
Copy link
Contributor Author

Released: https://nodejs.org/en/blog/release/v8.2.1/

Fishrock123 added a commit to nodejs/nodejs.org that referenced this pull request Jul 28, 2017
@Fishrock123
Blog: update 8.2.1 with armv6l link
4d2a045 
Refs: nodejs/node#13737
PR-URL: nodejs/node#14399
This was referenced Aug 11, 2017
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mscdex mscdex mscdex left review comments

Assignees

@Fishrock123 Fishrock123

Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Fishrock123 @mscdex @nodejs-github-bot @mcollina